aboutsummaryrefslogtreecommitdiff
path: root/docker/ironic-inspector
AgeCommit message (Collapse)AuthorFilesLines
2025-09-05Drop ironic-inspectorMichal Nasiadka3-64/+0
Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/951864 Change-Id: Ie7e607c5a9c6f8c2e36aea5d52dc2ffbe97dddb3 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2024-11-15Add mechanism for patching files in containersMichal Arbet1-0/+2
This patch adds a way to patch files in a Docker image built by Kolla. This is very useful for several reasons, specifically: - Custom modifications - The stable branch of some library has a fix but no pip package has been released - Eliminates the need to package your own pip packages - Eliminates the need to invent your own versioning to prevent upstream versioning - Eliminates the need to manage a pip server - In other words, it eliminates the need to get a wheel into the image and install it manually using any method not previously mentioned It is also highly desirable because, although Kolla can replace the source for a service with a custom URL for a tarball or its own Git repo, it cannot do this for dependencies pulled from pip. I would also like to point out that this is a feature with its own code path and works only if the user "inserts" a patch into the folder patches/docker-image/something.patch and creates an analogous series file for patch source code. Simply said, this code will never interfere with the upstream build process since this feature is not intended for use in upstream. It is rather meant for downstream users who know what they are doing. Now they just have an option to patch their images. Everything works on all layers of the Docker image and stores a report of applied patches which can then be seen in /etc. This mechanism is similar as debian patch quilt. Change-Id: I61d0790c5d4d070b7ea9e8c99c0a76ff5d22bf9d
2022-10-10Fix writable rootwrap/privsep configRadosław Piliszek1-1/+1
Fixes a hypothetical security issue related to privilege escalation via rootwrap/privsep. A potential vulnerable service could previously allow writes to its rootwrap/privsep config and thus allow for more commands to be run with root privileges via rootwrap/privsep. For a succesful attack, this would also require the service to allow to run arbitrary commands via rootwrap/privsep. Thus far, no such vulnerabilities have been reported and thus this fix is simply strengthening the container images against such an issue in the future. Change-Id: I92c81c77e6a16570a108cde8031f7977930fb02a Closes-Bug: #1874298
2022-04-21flatten images a bitMarcin Juszkiewicz1-9/+7
As we have one type of images now some RUN calls could be merged so we will have less layers in resulting images. Change-Id: I5178c58fbd8c65efe825dc249c0f1368ef0fe8e0
2022-04-11Adjust permissions on _extend_start files.Tim Shearer1-1/+1
Explicitly set the permissions on the kolla-toolbox kolla_extend_start file. Also, since all extend_start files are sourced rather than executed, the executable bits are now cleared throughout the project. Change-Id: I5c2deb4a2e33575d57c852089f856a9acc6818d0
2022-04-09docker: drop binary partsMarcin Juszkiewicz1-24/+5
Big patch drops all mentions of binary images support. Suggestions are welcome how to split it into parts or handle better. Change-Id: I5d5a46c6ce7734ceb8b844e17b43e359d7cac6e3
2020-12-20Install iptables in ironic-inspector containerdouyali1-1/+4
The centos environment ironic-inspector use iptables filter need install iptables rpm package. Change-Id: I67081a37977dd6de37a67fcd012e002f2e46743f Closes-bug: #1906635
2020-09-25Run Ironic Inspector as ironic-inspector usergeneralfuzz2-2/+2
This patch reverts changes to the Dockerfile and configuration script that were made to support running the service using wsgi. Ironic Inspector does not currently support running with wsgi. Change-Id: Idc816f25c85ef7d5cd14182fe01b652876cb181a
2020-08-19Enable mod_wsgi in Ironic API and Inspector containerJames Kirsch2-2/+2
This patch modifies the Dockerfile for both the Ironic API and Inspector so that the 'root' user executes the container setup scripts. This enables the container httpd configuration script to execute. Change-Id: I02b58ac571cd4eb3b9d4a814fe0cb907a3564e23
2020-03-01Add block labels to all DockerfilesChristian Berendt1-0/+2
Change-Id: I9692dda817ef134d647247431565e1b58cf9da41
2019-09-03ironic-inspector: install the dnsmasq subpackage explicitlyDmitry Tantsur1-1/+4
We are splitting the ironic-inspector package into RDO into ironic-inspector itself and its dnsmasq service. This change updates kolla to install both packages to avoid breakages when RDO removes mutual dependency between them. Change-Id: I2acb070f725aa563781dfe5d325834e1e2675edf
2019-06-09Fix ownership of ironic inspector DHCP hostsdirMark Goddard1-1/+2
If you run with enable_ironic set to true and ironic_inspector_pxe_filter set to dnsmasq (the default in stein), ironic inspector can fail with the following in the logs: Permission denied: u'/var/lib/ironic-inspector/dhcp-hostsdir/<MAC address>' A node must be registered with a port for this to happen. Weirdly this happens on centos/source, ubuntu/source, and ubuntu/binary, but not centos/binary. This change changes the ownership of /var/lib/ironic-inspector/dhcp-hostsdir to ironic-inspector user to make it writeable. Change-Id: I19447727f19dbd9c0a3e17d218b48ddc4c253587 Closes-Bug: #1832026
2019-01-17Use base_package_typeAlex Schultz1-3/+3
This change updates the docker files to use base_package_type instead of doing specific distro checks for the rhel/deb generic cases. The base_distro is still available and is used when a specific distro needs a customization but if the differences are purely rpm vs deb, then the base_package_type can be used. Change-Id: I8d720bb185df65a0178061ccf20b1ab2265da2c5
2017-05-03Override image's meta info.Jawon Choo1-1/+1
centos based images have wrong label info, these changes fix own image's name and build-date. Change-Id: I1d13f8f386c8db12b5fbe5f8ecbbf9e3fbb4ba1c Closes-Bug: #1680341
2017-04-20Use LABEL instead of MAINTAINER (deprecated) in all Dockerfile.j2Chen1-1/+1
Use LABEL instruction instead of MAINTAINER (deprecated) instruc- tion as suggested by Docker's official dockerfile guide. docs.docker.com/engine/reference/builder/#maintainer-deprecated Closes-Bug: #1683652 Change-Id: Ie87a1ddf31aefcd0b623fd2837d78de420e76898
2017-04-17Use ironic-inspector user for ironic-inspectorMark Goddard3-0/+74
This change updates the ironic-inspector image to use the ironic-inspector user rather than the ironic user to execute the ironic inspector service as this more closely aligns with what is typically done by downstream packagers (specifically, Ubuntu and RDO). This change rebases the ironic-inspector image onto the openstack-base image instead of the ironic-base image. We configure an ironic-inspector user and use this to execute the ironic-inspector service. We also configure ironic-inspector to log to /var/log/kolla/ironic-inspector instead of the previous ironic location. Following this change we no longer need the workaround of a sudoers file for the binary install type that was added in change I8ecd0b658b8df8f38ddf717fa9443d4dc2896984. Change-Id: Ibdc5ba35db61f4974d4282aff34bcb5ccd952d45 Closes-Bug: #1624457