diff options
| author | Martin André <martin.andre@kvhasia.com> | 2015-06-03 10:22:57 +0900 |
|---|---|---|
| committer | Martin André <martin.andre@kvhasia.com> | 2015-06-03 10:22:57 +0900 |
| commit | 9a5fed6608aad97ddefc31c030eb0d76c02320e5 (patch) | |
| tree | 519f136908fb5c5762985ae7d8700efa1d10fba1 /tools | |
| parent | f69084a5aa2a70444753e6e4611618116547ba2d (diff) | |
| download | kolla-9a5fed6608aad97ddefc31c030eb0d76c02320e5.tar.gz kolla-9a5fed6608aad97ddefc31c030eb0d76c02320e5.zip | |
Fail image build when build script is missing
When an image did not provide a build script, due to a broken link for
instance, the build-all-docker-images script was wrongly marking the
image as "up-to-date", and the functional gate was reporting success.
This commit restores the expected behavior, and mark the images with
non-existent build scripts as failures.
Change-Id: Ifedc8d9c312925fe5aa953ed8f8fdae02b756906
Closes-Bug: #1460959
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/build-all-docker-images | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/build-all-docker-images b/tools/build-all-docker-images index 888d25aac..86046fa47 100755 --- a/tools/build-all-docker-images +++ b/tools/build-all-docker-images @@ -54,8 +54,8 @@ function requires_build { function build_image { local dir=$1 + printf "\n" if [ -x "$dir/build" ]; then - printf "\n" info "Building image in $dir" if $dir/build $ARGS --no-use-released-parent; then success "Successfully built image in $dir" @@ -64,6 +64,9 @@ function build_image { warn "Failed to build image in $dir" status[$image]="fail" fi + else + warn "Image $image does not provide build script" + status[$image]="fail" fi } |
