aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorBorne Mace <borne.mace@oracle.com>2015-07-10 12:01:28 -0700
committerBorne Mace <borne.mace@oracle.com>2015-07-10 12:01:28 -0700
commit30a1988f0aba4749ce03107f14f34b1602c64a35 (patch)
tree802a8a6fe1b58d1b242658387a34527b0089774b /tests
parent5a758fc6d1e951e3fa7c4e1c54dae7e96595f6ab (diff)
downloadkolla-30a1988f0aba4749ce03107f14f34b1602c64a35.tar.gz
kolla-30a1988f0aba4749ce03107f14f34b1602c64a35.zip
Fixed additional OpenStack pep8 issues
The "hacking" package used in most OpenStack repos pulls in additional pep8 rules. This commit should fix all of them other than a hand full in the build.py file which will be fixed in a separate commit Change-Id: I40a0a30d338592ad64123e3da5523b9ad95a7a9c Partially-Implements: blueprint enable-flake8
Diffstat (limited to 'tests')
-rw-r--r--tests/clients.py6
-rw-r--r--tests/test_images.py4
-rw-r--r--tests/test_keystone.py2
3 files changed, 7 insertions, 5 deletions
diff --git a/tests/clients.py b/tests/clients.py
index 9544e239b..6b2aef528 100644
--- a/tests/clients.py
+++ b/tests/clients.py
@@ -11,8 +11,8 @@
# under the License.
-import logging
from keystoneclient.v2_0 import client as ksclient
+import logging
logging.basicConfig(level=logging.WARNING)
LOG = logging.getLogger(__name__)
@@ -48,7 +48,7 @@ class KeystoneClient(OpenStackClients):
def __init__(self):
super(KeystoneClient, self).__init__()
- # TODO: this shouldn't be hard coded
+ # TODO(Jeff Peeler): this shouldn't be hard coded
self.creds = {'auth_url': 'http://10.0.0.4:5000/v2.0',
'username': 'admin',
'password': 'steakfordinner',
@@ -61,7 +61,7 @@ class KeystoneClient(OpenStackClients):
if __name__ == '__main__':
- # TODO: mox this
+ # TODO(Jeff Peeler): mox this
client_mgr = OpenStackClients()
ks = client_mgr.get_client('KeystoneClient')
LOG.info(ks)
diff --git a/tests/test_images.py b/tests/test_images.py
index e8ee41bc0..b336930e9 100644
--- a/tests/test_images.py
+++ b/tests/test_images.py
@@ -14,7 +14,9 @@ from oslo_log import fixture as log_fixture
from oslo_log import log as logging
from oslotest import base
-from subprocess import Popen, PIPE, STDOUT
+from subprocess import PIPE
+from subprocess import Popen
+from subprocess import STDOUT
LOG = logging.getLogger(__name__)
diff --git a/tests/test_keystone.py b/tests/test_keystone.py
index 6c23a203c..a3a850314 100644
--- a/tests/test_keystone.py
+++ b/tests/test_keystone.py
@@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
-import testtools
from clients import OpenStackClients
+import testtools
class KeystoneTest(testtools.TestCase):