diff options
| author | Mark Goddard <mark@stackhpc.com> | 2020-03-16 12:54:11 +0000 |
|---|---|---|
| committer | Mark Goddard <mark@stackhpc.com> | 2020-03-16 14:39:16 +0000 |
| commit | dfddcce3a5bc98cbd177c984fd9d0a8bab51d40c (patch) | |
| tree | cf20145bc400267c1dcde6fd56931fa5dc201303 /releasenotes | |
| parent | 5498671b344e48d6db865887537ff15cf4028510 (diff) | |
| download | kolla-dfddcce3a5bc98cbd177c984fd9d0a8bab51d40c.tar.gz kolla-dfddcce3a5bc98cbd177c984fd9d0a8bab51d40c.zip | |
Fix --skip-existing and --skip-parents
There are currently a few corner cases with the --skip-existing and
--skip-parents flags. Examples:
1. kolla-build --type source --skip-parents monasca-grafana
This does not try to build the monasca-grafana image. This appears to be
an issue when the image is a grandchild.
2. kolla-build --type source --skip-parents
This will build all images. Expect it to skip parents.
3. kolla-build --type source --skip-existing
This will build all images. Expect it to skip existing images.
The filter_images method does quite a lot, including handling
whether images are buildable, regex/profile matching, and which images
to skip. The matching and skipping parts are done in a single pass,
which can lead to some weird effects due to dependencies between the
images and their statuses. Also, skipping is only currently applied when
there is a regex/profile filter.
This change splits out the matching and skipping into two separate
passes. In the first pass, we mark all buildable images that match the
filter as matched. In the second, we iterate over matched images,
applying the skip existing and skip parents rules.
Change-Id: I2f895aea0cc59d808129e9fc636af0890196af33
Closes-Bug: #1867614
Related-Bug: #1810979
Diffstat (limited to 'releasenotes')
| -rw-r--r-- | releasenotes/notes/fix-skips-d5cb9546110300ee.yaml | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/releasenotes/notes/fix-skips-d5cb9546110300ee.yaml b/releasenotes/notes/fix-skips-d5cb9546110300ee.yaml new file mode 100644 index 000000000..c3f427a2a --- /dev/null +++ b/releasenotes/notes/fix-skips-d5cb9546110300ee.yaml @@ -0,0 +1,11 @@ +--- +fixes: + - | + Fixes an issue with the ``--skip-existing`` and ``--skip-parents`` flags + which could cause images to not build. `LP#1867614 + <https://launchpad.net/bugs/1867614>`__. +upgrade: + - | + Changes the behaviour of the ``--skip-existing`` and ``--skip-parents`` + flags. Previously these were not applied if no regular expression or + profile argument was provided to ``kolla-build``, but now they are. |