diff options
| author | Jenkins <jenkins@review.openstack.org> | 2016-09-07 15:57:22 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2016-09-07 15:57:22 +0000 |
| commit | 33ace47bd3e284639f3d23a59fbed74912321318 (patch) | |
| tree | d7e99af5972d926ed448c12b57c6a2c9db4c523c /kolla | |
| parent | 5d8878de6ddcde8d30b1dee7b1c8ac15af4112ea (diff) | |
| parent | 23921f11eb7fa24055a03ccafab393553b58e063 (diff) | |
| download | kolla-33ace47bd3e284639f3d23a59fbed74912321318.tar.gz kolla-33ace47bd3e284639f3d23a59fbed74912321318.zip | |
Merge "Ensure doesn't use LOG.warn"
Diffstat (limited to 'kolla')
| -rw-r--r-- | kolla/hacking/checks.py | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/kolla/hacking/checks.py b/kolla/hacking/checks.py index 5a86fe571..9eba06c01 100644 --- a/kolla/hacking/checks.py +++ b/kolla/hacking/checks.py @@ -16,6 +16,19 @@ import re mutable_default_args = re.compile(r"^\s*def .+\((.+=\{\}|.+=\[\])") +def no_log_warn(logical_line): + """Disallow 'LOG.warn(' + + Deprecated LOG.warn(), instead use LOG.warning + https://bugs.launchpad.net/senlin/+bug/1508442 + N352 + """ + + msg = ("N352: LOG.warn is deprecated, please use LOG.warning!") + if "LOG.warn(" in logical_line: + yield (0, msg) + + def no_mutable_default_args(logical_line): msg = "N301: Method's default argument shouldn't be mutable!" if mutable_default_args.match(logical_line): @@ -24,3 +37,4 @@ def no_mutable_default_args(logical_line): def factory(register): register(no_mutable_default_args) + register(no_log_warn) |