aboutsummaryrefslogtreecommitdiff
path: root/docker/murano
diff options
context:
space:
mode:
authorShaun Smekel <shaun.smekel@theorem.net.au>2016-08-12 08:24:11 +1000
committerPaul Bourke <paul.bourke@oracle.com>2016-08-19 10:49:03 +0000
commita9d08726f5a48eef77c04ea1acefc00d93ce7076 (patch)
tree73762d7fd4f9b95cba8fbefe273de9a9db8eabb7 /docker/murano
parent0b7e853784c2c0db115b0e72a3f7fc58c86c7660 (diff)
downloadkolla-a9d08726f5a48eef77c04ea1acefc00d93ce7076.tar.gz
kolla-a9d08726f5a48eef77c04ea1acefc00d93ce7076.zip
Handle empty package list for install_packages
Currently if the install_packages macro is run with an empty package list, it will add a yum or apt-get command with no packages listed. This bug fix aims to omit this line when no packages have been given, or, the operator wants to use the "_override" / "_remove" functionality to disable all packages being installed in a Dockerfile. Co-Authored-By: Paul Bourke <paul.bourke@oracle.com> Change-Id: Ifaaaebfccc3adb0f2f68a35ac08e59378bc87fdb Closes-bug: 1612446
Diffstat (limited to 'docker/murano')
-rw-r--r--docker/murano/murano-api/Dockerfile.j22
-rw-r--r--docker/murano/murano-base/Dockerfile.j22
-rw-r--r--docker/murano/murano-engine/Dockerfile.j22
3 files changed, 3 insertions, 3 deletions
diff --git a/docker/murano/murano-api/Dockerfile.j2 b/docker/murano/murano-api/Dockerfile.j2
index 9d2890597..611d3131c 100644
--- a/docker/murano/murano-api/Dockerfile.j2
+++ b/docker/murano/murano-api/Dockerfile.j2
@@ -9,7 +9,7 @@ MAINTAINER {{ maintainer }}
{% set murano_api_packages = ['murano-api'] %}
{% endif %}
-RUN {{ macros.install_packages(murano_api_packages | customizable("packages")) }}
+{{ macros.install_packages(murano_api_packages | customizable("packages")) }}
{% endif %}
diff --git a/docker/murano/murano-base/Dockerfile.j2 b/docker/murano/murano-base/Dockerfile.j2
index b9fe141d1..5649cc56b 100644
--- a/docker/murano/murano-base/Dockerfile.j2
+++ b/docker/murano/murano-base/Dockerfile.j2
@@ -11,7 +11,7 @@ MAINTAINER {{ maintainer }}
{% set murano_base_packages = ['murano-common'] %}
{% endif %}
-RUN {{ macros.install_packages(murano_base_packages | customizable("packages")) }}
+{{ macros.install_packages(murano_base_packages | customizable("packages")) }}
{% elif install_type == 'source' %}
diff --git a/docker/murano/murano-engine/Dockerfile.j2 b/docker/murano/murano-engine/Dockerfile.j2
index 9a2395ad5..825831e49 100644
--- a/docker/murano/murano-engine/Dockerfile.j2
+++ b/docker/murano/murano-engine/Dockerfile.j2
@@ -10,7 +10,7 @@ MAINTAINER {{ maintainer }}
{% set murano_engine_packages = ['murano-engine'] %}
{% endif %}
-RUN {{ macros.install_packages(murano_engine_packages | customizable("packages")) }}
+{{ macros.install_packages(murano_engine_packages | customizable("packages")) }}
{% endif %}