diff options
| author | Shaun Smekel <shaun.smekel@theorem.net.au> | 2016-08-12 08:24:11 +1000 |
|---|---|---|
| committer | Paul Bourke <paul.bourke@oracle.com> | 2016-08-19 10:49:03 +0000 |
| commit | a9d08726f5a48eef77c04ea1acefc00d93ce7076 (patch) | |
| tree | 73762d7fd4f9b95cba8fbefe273de9a9db8eabb7 /docker/mistral | |
| parent | 0b7e853784c2c0db115b0e72a3f7fc58c86c7660 (diff) | |
| download | kolla-a9d08726f5a48eef77c04ea1acefc00d93ce7076.tar.gz kolla-a9d08726f5a48eef77c04ea1acefc00d93ce7076.zip | |
Handle empty package list for install_packages
Currently if the install_packages macro is run with an empty
package list, it will add a yum or apt-get command with no
packages listed.
This bug fix aims to omit this line when no packages have
been given, or, the operator wants to use the "_override" /
"_remove" functionality to disable all packages being
installed in a Dockerfile.
Co-Authored-By: Paul Bourke <paul.bourke@oracle.com>
Change-Id: Ifaaaebfccc3adb0f2f68a35ac08e59378bc87fdb
Closes-bug: 1612446
Diffstat (limited to 'docker/mistral')
| -rw-r--r-- | docker/mistral/mistral-api/Dockerfile.j2 | 2 | ||||
| -rw-r--r-- | docker/mistral/mistral-base/Dockerfile.j2 | 2 | ||||
| -rw-r--r-- | docker/mistral/mistral-engine/Dockerfile.j2 | 2 | ||||
| -rw-r--r-- | docker/mistral/mistral-executor/Dockerfile.j2 | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/docker/mistral/mistral-api/Dockerfile.j2 b/docker/mistral/mistral-api/Dockerfile.j2 index ed90c8b0b..80f0c7871 100644 --- a/docker/mistral/mistral-api/Dockerfile.j2 +++ b/docker/mistral/mistral-api/Dockerfile.j2 @@ -8,7 +8,7 @@ MAINTAINER {{ maintainer }} {% elif base_distro in ['ubuntu'] %} {% set mistral_api_packages = ['mistral-api'] %} {% endif %} -RUN {{ macros.install_packages(mistral_api_packages | customizable("packages")) }} +{{ macros.install_packages(mistral_api_packages | customizable("packages")) }} {% endif %} COPY extend_start.sh /usr/local/bin/kolla_mistral_extend_start diff --git a/docker/mistral/mistral-base/Dockerfile.j2 b/docker/mistral/mistral-base/Dockerfile.j2 index a31286799..5c7c90ed7 100644 --- a/docker/mistral/mistral-base/Dockerfile.j2 +++ b/docker/mistral/mistral-base/Dockerfile.j2 @@ -10,7 +10,7 @@ MAINTAINER {{ maintainer }} {% elif base_distro in ['ubuntu'] %} {% set mistral_base_packages = ['mistral-common'] %} {% endif %} -RUN {{ macros.install_packages(mistral_base_packages | customizable("packages")) }} +{{ macros.install_packages(mistral_base_packages | customizable("packages")) }} {% elif install_type == 'source' %} diff --git a/docker/mistral/mistral-engine/Dockerfile.j2 b/docker/mistral/mistral-engine/Dockerfile.j2 index f12f3d868..ed55401eb 100644 --- a/docker/mistral/mistral-engine/Dockerfile.j2 +++ b/docker/mistral/mistral-engine/Dockerfile.j2 @@ -9,7 +9,7 @@ MAINTAINER {{ maintainer }} {% elif base_distro in ['ubuntu'] %} {% set mistral_engine_packages = ['mistral-engine'] %} {% endif %} -RUN {{ macros.install_packages(mistral_engine_packages | customizable("packages")) }} +{{ macros.install_packages(mistral_engine_packages | customizable("packages")) }} {% endif %} {% block mistral_engine_footer %}{% endblock %} diff --git a/docker/mistral/mistral-executor/Dockerfile.j2 b/docker/mistral/mistral-executor/Dockerfile.j2 index 3ab176bd7..e52af6093 100644 --- a/docker/mistral/mistral-executor/Dockerfile.j2 +++ b/docker/mistral/mistral-executor/Dockerfile.j2 @@ -9,7 +9,7 @@ MAINTAINER {{ maintainer }} {% elif base_distro in ['ubuntu'] %} {% set mistral_executor_packages = ['mistral-executor'] %} {% endif %} -RUN {{ macros.install_packages(mistral_executor_packages | customizable("packages")) }} +{{ macros.install_packages(mistral_executor_packages | customizable("packages")) }} {% endif %} {% block mistral_executor_footer %}{% endblock %} |