aboutsummaryrefslogtreecommitdiff
path: root/docker/horizon
diff options
context:
space:
mode:
authorShaun Smekel <shaun.smekel@theorem.net.au>2016-08-12 08:24:11 +1000
committerPaul Bourke <paul.bourke@oracle.com>2016-08-19 10:49:03 +0000
commita9d08726f5a48eef77c04ea1acefc00d93ce7076 (patch)
tree73762d7fd4f9b95cba8fbefe273de9a9db8eabb7 /docker/horizon
parent0b7e853784c2c0db115b0e72a3f7fc58c86c7660 (diff)
downloadkolla-a9d08726f5a48eef77c04ea1acefc00d93ce7076.tar.gz
kolla-a9d08726f5a48eef77c04ea1acefc00d93ce7076.zip
Handle empty package list for install_packages
Currently if the install_packages macro is run with an empty package list, it will add a yum or apt-get command with no packages listed. This bug fix aims to omit this line when no packages have been given, or, the operator wants to use the "_override" / "_remove" functionality to disable all packages being installed in a Dockerfile. Co-Authored-By: Paul Bourke <paul.bourke@oracle.com> Change-Id: Ifaaaebfccc3adb0f2f68a35ac08e59378bc87fdb Closes-bug: 1612446
Diffstat (limited to 'docker/horizon')
-rw-r--r--docker/horizon/Dockerfile.j28
1 files changed, 4 insertions, 4 deletions
diff --git a/docker/horizon/Dockerfile.j2 b/docker/horizon/Dockerfile.j2
index 40b8117e2..6f680b516 100644
--- a/docker/horizon/Dockerfile.j2
+++ b/docker/horizon/Dockerfile.j2
@@ -13,7 +13,7 @@ MAINTAINER {{ maintainer }}
'gettext'
] %}
-RUN {{ macros.install_packages(horizon_packages | customizable("packages")) }}
+{{ macros.install_packages(horizon_packages | customizable("packages")) }}
{% block horizon_redhat_binary_setup %}
RUN useradd --user-group horizon \
@@ -38,7 +38,7 @@ RUN useradd --user-group horizon \
'gettext'
] %}
-RUN {{ macros.install_packages(horizon_packages | customizable("packages")) }}
+{{ macros.install_packages(horizon_packages | customizable("packages")) }}
{% block horizon_ubuntu_binary_setup %}
RUN echo > /etc/apache2/ports.conf \
@@ -69,7 +69,7 @@ RUN echo > /etc/apache2/ports.conf \
'gettext'
] %}
-RUN {{ macros.install_packages(horizon_packages | customizable("packages")) }}
+{{ macros.install_packages(horizon_packages | customizable("packages")) }}
{% block horizon_redhat_source_setup %}
RUN sed -i -r 's,^(Listen 80),#\1,' /etc/httpd/conf/httpd.conf
@@ -83,7 +83,7 @@ RUN sed -i -r 's,^(Listen 80),#\1,' /etc/httpd/conf/httpd.conf
'gettext'
] %}
-RUN {{ macros.install_packages(horizon_packages | customizable("packages")) }}
+{{ macros.install_packages(horizon_packages | customizable("packages")) }}
{% block horizon_ubuntu_source_setup %}
RUN echo > /etc/apache2/ports.conf \