aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcin Juszkiewicz <marcin.juszkiewicz+kolla@linaro.org>2022-04-19 13:21:25 +0200
committerMarcin Juszkiewicz <marcin.juszkiewicz+kolla@linaro.org>2022-04-19 16:23:12 +0200
commite877556aafb2b571152567a8fc1f6ec640ffb2a4 (patch)
tree901a6508c5c15b96c784baecc416b448d4df56aa
parent0cf5b1d4e6e871562c0ca0f48a21594f8d197471 (diff)
downloadkolla-e877556aafb2b571152567a8fc1f6ec640ffb2a4.tar.gz
kolla-e877556aafb2b571152567a8fc1f6ec640ffb2a4.zip
add a way to not have 'install_type' in image name (temporary)
--use-short-names argument drops 'install_type' from image names: kolla/debian-openstack-base:14.1.0 This should allow to get rid of '-source' in image names without disrupting CI jobs. Switch publish jobs to use short names so k-a tests will have ready to use images for both long and short names. Change-Id: I29c9d51f4b518a4e2d3157ab5d6cc434fb83f2ef
-rwxr-xr-xkolla/common/config.py5
-rwxr-xr-xkolla/image/build.py6
-rw-r--r--tests/playbooks/run.yml2
3 files changed, 10 insertions, 3 deletions
diff --git a/kolla/common/config.py b/kolla/common/config.py
index dda2e2010..8e31fc9f5 100755
--- a/kolla/common/config.py
+++ b/kolla/common/config.py
@@ -248,7 +248,10 @@ _CLI_OPTS = [
cfg.BoolOpt('enable-unbuildable', default=False,
help='Enable images marked as unbuildable'),
cfg.BoolOpt('summary', default=True,
- help='Show summary at the end of build')
+ help='Show summary at the end of build'),
+ cfg.BoolOpt('use-short-names', default=False,
+ help='Use image names without install_type '
+ '(transition option - to be removed)')
]
_BASE_OPTS = [
diff --git a/kolla/image/build.py b/kolla/image/build.py
index 7d8091682..dbd5dd6a3 100755
--- a/kolla/image/build.py
+++ b/kolla/image/build.py
@@ -647,8 +647,10 @@ class KollaWorker(object):
self.clean_package_cache = self.conf.clean_package_cache
- # TODO(hrw): to remove "source-" in a later patch
- self.image_prefix = self.base + '-source-'
+ if self.conf.use_short_names:
+ self.image_prefix = self.base + '-'
+ else:
+ self.image_prefix = self.base + '-source-'
self.regex = conf.regex
self.image_statuses_bad = dict()
diff --git a/tests/playbooks/run.yml b/tests/playbooks/run.yml
index 9b544b30f..6ed25975b 100644
--- a/tests/playbooks/run.yml
+++ b/tests/playbooks/run.yml
@@ -28,6 +28,8 @@
DEFAULT:
namespace: "{{ kolla_namespace }}"
tag: "{{ (zuul.branch | basename) ~ tag_suffix }}"
+ # NOTE(hrw): we want to publish short names
+ use_short_names: true
set_fact:
kolla_build_config: "{{ kolla_build_config | combine(kolla_publisher_config, recursive=True) }}"
when: