aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Goddard <mark@stackhpc.com>2021-09-29 16:39:40 +0100
committerMark Goddard <mark@stackhpc.com>2021-09-30 09:07:10 +0100
commite4f019a5ddfca68c7f0ac5cbfdeb47e88e170d20 (patch)
tree92f284c88053400dc616f88687e73cabedc621e4
parente6c124f6c29e47e3365c0f395ea5618dcbb78280 (diff)
downloadkolla-e4f019a5ddfca68c7f0ac5cbfdeb47e88e170d20.tar.gz
kolla-e4f019a5ddfca68c7f0ac5cbfdeb47e88e170d20.zip
Build source type images by default
Source images get the most test coverage, so it makes sense to build these by default. Change-Id: Ie10a41a94af95075a1b91feb2b74ade02b17117e
-rw-r--r--doc/source/admin/image-building.rst4
-rwxr-xr-xkolla/common/config.py2
-rw-r--r--releasenotes/notes/default-type-source-f0c5cf1d97e2f345.yaml8
3 files changed, 11 insertions, 3 deletions
diff --git a/doc/source/admin/image-building.rst b/doc/source/admin/image-building.rst
index f5a110a7a..00281e5c1 100644
--- a/doc/source/admin/image-building.rst
+++ b/doc/source/admin/image-building.rst
@@ -118,11 +118,11 @@ When building images, there are two methods of the OpenStack install. One is
``binary``. Another is ``source``. The ``binary`` means that OpenStack will be
installed from apt/dnf. And the ``source`` means that OpenStack will be
installed from upstream sources. The default method of the OpenStack install is
-``binary``. It can be changed to ``source`` using the ``-t`` option:
+``source``. It can be changed to ``binary`` using the ``-t`` option:
.. code-block:: console
- kolla-build -t source
+ kolla-build -t binary
The locations of OpenStack source code are written in ``kolla-build.conf``.
The source type supports ``url``, ``git``, and ``local``. The location of
diff --git a/kolla/common/config.py b/kolla/common/config.py
index e08a84415..b8f9a4661 100755
--- a/kolla/common/config.py
+++ b/kolla/common/config.py
@@ -203,7 +203,7 @@ _CLI_OPTS = [
help='Format to write the final results in'),
cfg.StrOpt('tarballs-base', default=TARBALLS_BASE,
help='Base url to OpenStack tarballs'),
- cfg.StrOpt('type', short='t', default='binary',
+ cfg.StrOpt('type', short='t', default='source',
choices=INSTALL_TYPE_CHOICES,
dest='install_type',
help=('The method of the OpenStack install.')),
diff --git a/releasenotes/notes/default-type-source-f0c5cf1d97e2f345.yaml b/releasenotes/notes/default-type-source-f0c5cf1d97e2f345.yaml
new file mode 100644
index 000000000..62a019d67
--- /dev/null
+++ b/releasenotes/notes/default-type-source-f0c5cf1d97e2f345.yaml
@@ -0,0 +1,8 @@
+---
+upgrade:
+ - |
+ Updates the default image type to ``source``. Users wishing to build
+ ``binary`` type images should either specify the ``--type binary`` CLI
+ argument or set ``[DEFAULT] type=binary`` in ``kolla-build.conf``.
+ This change is to reflect the reality that source images are tested more
+ thoroughly and we (as OpenStack community) have better control over them.