aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.opendev.org>2023-05-18 10:47:07 +0000
committerGerrit Code Review <review@openstack.org>2023-05-18 10:47:07 +0000
commitc4ee8d88feecca90d34adc10af0c6fc8a213e086 (patch)
tree2a0977a04ea59a2491024271bdb8d2f98ab15fef
parentac92a58d8695891b18d0868e77cfcb3d2080975d (diff)
parent050e26ed89b307a2037f118e314d0a44249a0f89 (diff)
downloadkolla-c4ee8d88feecca90d34adc10af0c6fc8a213e086.tar.gz
kolla-c4ee8d88feecca90d34adc10af0c6fc8a213e086.zip
Merge "Fix docker version check after docker-py>=6.0.0"
-rw-r--r--kolla/engine_adapter/engine.py2
-rw-r--r--kolla/image/build.py3
2 files changed, 3 insertions, 2 deletions
diff --git a/kolla/engine_adapter/engine.py b/kolla/engine_adapter/engine.py
index 184bb3856..dc608204c 100644
--- a/kolla/engine_adapter/engine.py
+++ b/kolla/engine_adapter/engine.py
@@ -52,6 +52,6 @@ def getEngineClient(conf):
def getEngineVersion(conf):
if conf.engine == Engine.DOCKER.value:
- return StrictVersion(docker.version)
+ return StrictVersion(docker.__version__)
else:
raise UnsupportedEngineError(conf.engine)
diff --git a/kolla/image/build.py b/kolla/image/build.py
index fdf1635c8..2c0388416 100644
--- a/kolla/image/build.py
+++ b/kolla/image/build.py
@@ -19,6 +19,7 @@ import sys
import threading
import time
+from distutils.version import StrictVersion
from kolla.common import config as common_config
from kolla.common import utils
from kolla.engine_adapter import engine
@@ -113,7 +114,7 @@ def run_build():
if conf.engine == engine.Engine.DOCKER.value:
try:
import docker
- docker.version
+ StrictVersion(docker.__version__)
except ImportError:
LOG.error("Error, you have set Docker as container engine, "
"but the Python library is not found."