aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2016-08-19 15:53:10 +0000
committerGerrit Code Review <review@openstack.org>2016-08-19 15:53:10 +0000
commit8b49d6611e85682bbb8fb833c099ac4a63494014 (patch)
treede5426bf6d896406508fb973ee5d6be4bc664ce0
parentedf0d99dcc9fa1a285283049627623d872fbe807 (diff)
parenta01b803b53bd77dcbae57e9f7647442a3e6e3f0f (diff)
downloadkolla-8b49d6611e85682bbb8fb833c099ac4a63494014.tar.gz
kolla-8b49d6611e85682bbb8fb833c099ac4a63494014.zip
Merge "Add basic checking for network_interface to prechecks"
-rw-r--r--ansible/roles/prechecks/tasks/port_checks.yml16
-rw-r--r--releasenotes/notes/add-network-interface-checks-0e789f3f93cbdb09.yaml3
2 files changed, 19 insertions, 0 deletions
diff --git a/ansible/roles/prechecks/tasks/port_checks.yml b/ansible/roles/prechecks/tasks/port_checks.yml
index 401cd2368..7f8724aae 100644
--- a/ansible/roles/prechecks/tasks/port_checks.yml
+++ b/ansible/roles/prechecks/tasks/port_checks.yml
@@ -448,3 +448,19 @@
failed_when: "'169.254.' not in kolla_internal_vip_address and \
kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3]) is none"
when: enable_haproxy | bool
+
+- name: Checking the network_interface is present
+ fail: "msg='Please check the network_interface property - interface {{ network_interface }} not found'"
+ when: network_interface not in ansible_interfaces
+
+- name: Checking the network_interface is active
+ fail: "msg='Please check the network_interface settings - interface {{ network_interface }} is not active'"
+ when: hostvars[inventory_hostname]['ansible_' + network_interface]['active'] != True
+
+- name: Checking the network_interface configuration
+ fail: "msg='Please check the network_interface settings - interface {{ network_interface }} configuration missing'"
+ when: hostvars[inventory_hostname]['ansible_' + network_interface]['ipv4'] is not defined
+
+- name: Checking the network_interface ip address configuration
+ fail: "msg='Please check the network_interface settings - interface {{ network_interface }} ip address problem'"
+ when: hostvars[inventory_hostname]['ansible_' + network_interface]['ipv4']['address'] is not defined
diff --git a/releasenotes/notes/add-network-interface-checks-0e789f3f93cbdb09.yaml b/releasenotes/notes/add-network-interface-checks-0e789f3f93cbdb09.yaml
new file mode 100644
index 000000000..3232fb518
--- /dev/null
+++ b/releasenotes/notes/add-network-interface-checks-0e789f3f93cbdb09.yaml
@@ -0,0 +1,3 @@
+---
+features:
+ - Add some extra prechecks to ensure a sane NIC config.