diff options
| author | lingyongxu <lyxu@fiberhome.com> | 2017-03-23 14:36:58 +0800 |
|---|---|---|
| committer | Lingyong Xu <lyxu@fiberhome.com> | 2017-03-23 06:38:50 +0000 |
| commit | 27dbefb4aeca6b2626b2a54cc6e3e97265fa34a2 (patch) | |
| tree | 5c0cbd5d4eb5c54b0f0a09cb8f7a3c7e5ce3bb8e | |
| parent | f5a9c8c71c7b663ea286fd6779997053713a05fb (diff) | |
| download | kolla-27dbefb4aeca6b2626b2a54cc6e3e97265fa34a2.tar.gz kolla-27dbefb4aeca6b2626b2a54cc6e3e97265fa34a2.zip | |
Using assertIsNone() instead of assertEqual(None)
Following OpenStack Style Guidelines:
[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred over
assertEqual(None, ...) and assertIs(..., None)
Change-Id: If18685d75a847571c62dd1424c7b71433bbd4ce4
| -rw-r--r-- | kolla/tests/test_build.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kolla/tests/test_build.py b/kolla/tests/test_build.py index 7bcd2de7f..a5b020b1b 100644 --- a/kolla/tests/test_build.py +++ b/kolla/tests/test_build.py @@ -347,7 +347,7 @@ class KollaWorkerTest(base.TestCase): kolla.image_statuses_bad['bad'] = None kolla.image_statuses_unmatched['unmatched'] = None results = kolla.summary() - self.assertEqual(None, results['failed'][0]['status']) + self.assertIsNone(results['failed'][0]['status']) @mock.patch('shutil.copytree') def test_work_dir(self, copytree_mock): |