From 253692630f156e81a7ea33d1fa9fc3708939a9c0 Mon Sep 17 00:00:00 2001 From: Nguyen Hung Phuong Date: Mon, 12 Sep 2016 15:15:21 +0700 Subject: Clean imports in code In some part in the code we import objects. In the Openstack style guidelines they recommend to import only modules. http://docs.openstack.org/developer/hacking/#imports Change-Id: I4b55cae8c2672f82025a95112b14d441d66f9d6d --- tools/version-check.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'tools/version-check.py') diff --git a/tools/version-check.py b/tools/version-check.py index a20d14b79..9477762b0 100755 --- a/tools/version-check.py +++ b/tools/version-check.py @@ -18,10 +18,10 @@ import os import re import sys -from bs4 import BeautifulSoup as bs +import bs4 from oslo_config import cfg import pkg_resources -from prettytable import PrettyTable +import prettytable import requests PROJECT_ROOT = os.path.abspath(os.path.join( @@ -58,7 +58,7 @@ def retrieve_upstream_versions(): LOG.debug("Getting latest version for project %s from %s", project, base) r = requests.get(base) - s = bs(r.text, 'html.parser') + s = bs4.BeautifulSoup(r.text, 'html.parser') for link in s.find_all('a'): version = link.get('href') @@ -119,8 +119,8 @@ def diff_link(project, old_ref, new_ref): def compare_versions(): up_to_date = True - result = PrettyTable(["Project", "Current version", - "Latest version", "Comparing changes"]) + result = prettytable.PrettyTable(["Project", "Current version", + "Latest version", "Comparing changes"]) result.align = "l" for project in VERSIONS['upstream']: -- cgit v1.2.3