From 2fb98a6b829df9d16cfe132b1bd4eca7013ed2fa Mon Sep 17 00:00:00 2001 From: Lu lei Date: Tue, 23 Aug 2016 11:08:25 +0800 Subject: py3:Remove six.iterXXX MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1、As mentioned in [1], we should avoid using six.iteritems/keys achieve iterators. We can use dict.items/keys instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2、In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/ 2015-June/066391.html TrivialFix. Change-Id: I0cbe8af3210233a58d25f0df187c3d085405aa2a --- kolla/image/build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'kolla') diff --git a/kolla/image/build.py b/kolla/image/build.py index 0a2103516..990ca5265 100644 --- a/kolla/image/build.py +++ b/kolla/image/build.py @@ -861,7 +861,7 @@ class KollaWorker(object): return def list_children(images, ancestry): - children = six.next(six.itervalues(ancestry)) + children = six.next(ancestry.values()) for image in images: if image.status not in [STATUS_MATCHED]: continue -- cgit v1.2.3