From 2c2951b59b6e91c8f0ea6a82c1b3a9b16e1c02f7 Mon Sep 17 00:00:00 2001
From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Date: Thu, 2 Jan 2020 09:56:10 +0100
Subject: centos: disable EPEL by default

Our images use 'scsi-target-utils' from EPEL and then can be built
without it. So let's disable this repository right after installing
package from it.

Images can enable EPEL with 'enable_extra_repos' macro.

Also added 'disable_extra_repos' macro as we have some images in a need.

Change-Id: Id70474e7602b531b63fdc11ae690fd9ed33def74
---
 docker/base/Dockerfile.j2      | 1 +
 docker/collectd/Dockerfile.j2  | 4 ----
 docker/macros.j2               | 8 +++++++-
 docker/qdrouterd/Dockerfile.j2 | 2 +-
 4 files changed, 9 insertions(+), 6 deletions(-)

(limited to 'docker')

diff --git a/docker/base/Dockerfile.j2 b/docker/base/Dockerfile.j2
index 48522109d..dadfa8e9e 100644
--- a/docker/base/Dockerfile.j2
+++ b/docker/base/Dockerfile.j2
@@ -265,6 +265,7 @@ RUN yum-config-manager --enable rhel-7-server-optional-rpms \
 
 # Install base packages
 {{ macros.install_packages( base_centos_packages | customizable("centos_packages") | customizable("centos_binary_packages") | customizable("centos_source_packages") ) }}
+{{ macros.disable_extra_repos('epel') }}
 
 {# endif for base_package_type rpm #}
 {% elif base_package_type == 'deb' %}
diff --git a/docker/collectd/Dockerfile.j2 b/docker/collectd/Dockerfile.j2
index a3cc0747b..2f251c5fc 100644
--- a/docker/collectd/Dockerfile.j2
+++ b/docker/collectd/Dockerfile.j2
@@ -88,10 +88,6 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
     {% endif %}
 
   {% endif %}
-  {% if distro_package_manager == 'yum' %}
-# make sure, collectd is pulled from centos-opstools
-RUN yum-config-manager --disable epel
-  {% endif %}
 {% endif %}
 
 {{ macros.install_packages(collectd_packages | customizable("packages")) }}
diff --git a/docker/macros.j2 b/docker/macros.j2
index 8c698d278..67e65af8a 100644
--- a/docker/macros.j2
+++ b/docker/macros.j2
@@ -94,6 +94,12 @@ RUN usermod --append --home {{ homedir }} --groups kolla {{ name }} \
 
 {% macro enable_extra_repos(repos) %}
 
-{{ enable_repos(repos) }}
+{{ handle_repos(repos, 'enable') }}
+
+{% endmacro %}
+
+{% macro disable_extra_repos(repos) %}
+
+{{ handle_repos(repos, 'disable') }}
 
 {% endmacro %}
diff --git a/docker/qdrouterd/Dockerfile.j2 b/docker/qdrouterd/Dockerfile.j2
index 049bc5da1..a7885895c 100644
--- a/docker/qdrouterd/Dockerfile.j2
+++ b/docker/qdrouterd/Dockerfile.j2
@@ -20,7 +20,7 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
 
 {% if base_distro in ['centos'] %}
 # make sure qpid is pulled from centos-openstack-RELEASE (RDO) repo
-RUN {% if distro_package_manager == 'dnf' %}dnf config-manager{% else %}yum-config-manager{% endif %} --disable epel centos-release-opstools extras
+{{ macros.disable_extra_repos(['extras', 'opstools']) }}
 {% endif %}
 
 {{ macros.install_packages(qdrouterd_packages | customizable("packages")) }}
-- 
cgit v1.2.3