From cb4e875ae1e1ec2e6ddf8a6b37f42283697fd50c Mon Sep 17 00:00:00 2001
From: Sam Yaple <sam@yaple.net>
Date: Wed, 30 Sep 2015 11:23:39 +0000
Subject: Common start.sh

The majority of the start.sh code is identical. This removes that
duplicate code while still maintaining the ability to call code in a
specific container.

The start.sh is moved into /usr/local/bin/kolla_start in the container

The extend_start.sh script is called by the kolla_start script at the
location /usr/local/bin/kolla_extend_start . It always exists because
we create a noop kolla_extend_start in the base directory. We override
it with extend_start.sh in a specific image should we need to.

Of note, the neutron-agents container is exempt from this new
structure due to it being a fat container.

Additionally, we fix the inconsistent permissions throughout. 644 for
repo files and the scripts are set to 755 via a Docker RUN command to
ensure someones local perm change won't break upstream containers.

Change-Id: I7da8d19965463ad30ee522a71183e3f092e0d6ad
Closes-Bug: #1501295
---
 docker/keepalived/Dockerfile.j2   |  5 +++--
 docker/keepalived/check_alive.sh  |  0
 docker/keepalived/extend_start.sh |  8 ++++++++
 docker/keepalived/start.sh        | 14 --------------
 4 files changed, 11 insertions(+), 16 deletions(-)
 mode change 100755 => 100644 docker/keepalived/check_alive.sh
 create mode 100644 docker/keepalived/extend_start.sh
 delete mode 100755 docker/keepalived/start.sh

(limited to 'docker/keepalived')

diff --git a/docker/keepalived/Dockerfile.j2 b/docker/keepalived/Dockerfile.j2
index 9fbc7c49a..717439a6c 100644
--- a/docker/keepalived/Dockerfile.j2
+++ b/docker/keepalived/Dockerfile.j2
@@ -18,8 +18,9 @@ RUN apt-get install -y --no-install-recommends \
 
 {% endif %}
 
-COPY start.sh check_alive.sh /
+COPY check_alive.sh /
 
-CMD ["/start.sh"]
+COPY extend_start.sh /usr/local/bin/kolla_extend_start
+RUN chmod 755 /usr/local/bin/kolla_extend_start /check_alive.sh
 
 {{ include_footer }}
diff --git a/docker/keepalived/check_alive.sh b/docker/keepalived/check_alive.sh
old mode 100755
new mode 100644
diff --git a/docker/keepalived/extend_start.sh b/docker/keepalived/extend_start.sh
new file mode 100644
index 000000000..e1fe5d9d8
--- /dev/null
+++ b/docker/keepalived/extend_start.sh
@@ -0,0 +1,8 @@
+#!/bin/bash
+
+modprobe ip_vs
+
+# Workaround for bug #1485079
+if [ -f /run/keepalived.pid ]; then
+    rm /run/keepalived.pid
+fi
diff --git a/docker/keepalived/start.sh b/docker/keepalived/start.sh
deleted file mode 100755
index 1d96c3bfa..000000000
--- a/docker/keepalived/start.sh
+++ /dev/null
@@ -1,14 +0,0 @@
-#!/bin/bash
-set -o errexit
-
-# Loading common functions.
-source /opt/kolla/kolla-common.sh
-
-modprobe ip_vs
-
-# Workaround for bug #1485079
-if [ -f /run/keepalived.pid ]; then
-    rm /run/keepalived.pid
-fi
-
-exec $CMD
-- 
cgit v1.2.3