From 54e03d21ada70681f0f493f924534ca1f90a04ac Mon Sep 17 00:00:00 2001 From: Michal Nasiadka Date: Fri, 29 May 2026 07:54:24 +0200 Subject: doc: Improve code review guidelines Change-Id: I8fca57c43b032ec11e1fb95294ed85bf5876730e Signed-off-by: Michal Nasiadka --- doc/source/contributor/code-reviews.rst | 56 +++++++++++++++++++++++++++------ 1 file changed, 47 insertions(+), 9 deletions(-) (limited to 'doc/source') diff --git a/doc/source/contributor/code-reviews.rst b/doc/source/contributor/code-reviews.rst index 5fee74a1d..30a42c05e 100644 --- a/doc/source/contributor/code-reviews.rst +++ b/doc/source/contributor/code-reviews.rst @@ -18,26 +18,55 @@ The volume of emails is not too large if you subscribe to *New Changes* only. If you do not have much time available for reviewing, consider reviewing patches in an area that is important to you or that you understand well. -Core reviewers -============== +Core reviewer groups +==================== -Core reviewers have additional labels available to them. +There are two core reviewer groups in the Kolla project, each with different +levels of access. + +kolla-core +---------- + +Members of ``kolla-core`` have the following additional labels available: * +2: Approve * -2: Do not merge * Workflow +1: Approve and ready for merge Zuul requires one +2 and one workflow +1, as well as a passing check, in order -for a patch to proceed to the gate. The Kolla team generally requires two +2s -before a workflow +1 may be added. We also have some non-voting Zuul jobs which -will not block a check, but should be investigated if they are failing. +for a patch to proceed to the gate. + +We also have some non-voting Zuul jobs which will not block a check, but should +be investigated if they are failing. + +The Kolla project generally requires two +2s before a workflow +1 may be added. +Exceptions where a single +2 is sufficient before adding workflow +1 are: -Core reviewers may still use +1 to indicate approval if they are not confident -enough about a particular patch to use +2. +* CI-only patches +* Documentation patches +* Trivial patches -The Kolla core reviewers have the same rights of access to stable branches, so +``kolla-core`` members may still use +1 to indicate approval if they are not +confident enough about a particular patch to use +2. + +``kolla-core`` members have the same rights of access to stable branches, so always check the branch for a review, and use extra care with stable branches. +kolla-reviewers +--------------- + +Members of ``kolla-reviewers`` have the following additional labels available: + +* +2: Approve +* -2: Do not merge + +``kolla-reviewers`` members do not have workflow rights and cannot approve a +patch for merging. Their +2 counts toward the two +2s required before a +``kolla-core`` member may add a workflow +1. + +``kolla-reviewers`` members may still use +1 to indicate approval if they are +not confident enough about a particular patch to use +2. + Becoming a core reviewer ------------------------ @@ -45,3 +74,12 @@ There are no strict rules for becoming a core reviewer. Join the community, review some patches, and demonstrate responsibility, understanding & care. If you are interested in joining the core team, ask the PTL or another core reviewer how to get there. + +Stale patches +============= + +If a reviewed patch has received no response from its owner for two weeks, it +is at the discretion and motivation of the core reviewers to update and carry +that patch forward if they deem it valuable for the upcoming release. In that +case, the core reviewer taking ownership of the patch should add their own +DCO signoff (``Signed-off-by:``) to the commit message. -- cgit v1.2.3