From 27dbefb4aeca6b2626b2a54cc6e3e97265fa34a2 Mon Sep 17 00:00:00 2001 From: lingyongxu Date: Thu, 23 Mar 2017 14:36:58 +0800 Subject: Using assertIsNone() instead of assertEqual(None) Following OpenStack Style Guidelines: [1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises [H203] Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(...) is preferred over assertEqual(None, ...) and assertIs(..., None) Change-Id: If18685d75a847571c62dd1424c7b71433bbd4ce4 --- kolla/tests/test_build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kolla/tests/test_build.py b/kolla/tests/test_build.py index 7bcd2de7f..a5b020b1b 100644 --- a/kolla/tests/test_build.py +++ b/kolla/tests/test_build.py @@ -347,7 +347,7 @@ class KollaWorkerTest(base.TestCase): kolla.image_statuses_bad['bad'] = None kolla.image_statuses_unmatched['unmatched'] = None results = kolla.summary() - self.assertEqual(None, results['failed'][0]['status']) + self.assertIsNone(results['failed'][0]['status']) @mock.patch('shutil.copytree') def test_work_dir(self, copytree_mock): -- cgit v1.2.3