diff options
| author | Nguyen Phuong An <AnNP@vn.fujitsu.com> | 2016-09-01 15:52:58 +0700 |
|---|---|---|
| committer | Nguyen Phuong An <AnNP@vn.fujitsu.com> | 2016-09-05 04:27:29 +0000 |
| commit | 23921f11eb7fa24055a03ccafab393553b58e063 (patch) | |
| tree | efb51892d331d0503c3be4361093c2277927b33c /kolla/hacking | |
| parent | fdb33d04ec2b21c3a28184164666a33351841400 (diff) | |
| download | kolla-23921f11eb7fa24055a03ccafab393553b58e063.tar.gz kolla-23921f11eb7fa24055a03ccafab393553b58e063.zip | |
Ensure doesn't use LOG.warn
This patchs ensure doesn't use LOG.warn because LOG.warn deprecated
in Python 3 [1]. Using LOG.warning should be used instead.
[1] https://docs.python.org/3/library/logging.html#logging.warning
TrivialFix
Change-Id: I464314b33b8d4f31b6be0a765019e1f5668cc6d9
Diffstat (limited to 'kolla/hacking')
| -rw-r--r-- | kolla/hacking/checks.py | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/kolla/hacking/checks.py b/kolla/hacking/checks.py index 5a86fe571..9eba06c01 100644 --- a/kolla/hacking/checks.py +++ b/kolla/hacking/checks.py @@ -16,6 +16,19 @@ import re mutable_default_args = re.compile(r"^\s*def .+\((.+=\{\}|.+=\[\])") +def no_log_warn(logical_line): + """Disallow 'LOG.warn(' + + Deprecated LOG.warn(), instead use LOG.warning + https://bugs.launchpad.net/senlin/+bug/1508442 + N352 + """ + + msg = ("N352: LOG.warn is deprecated, please use LOG.warning!") + if "LOG.warn(" in logical_line: + yield (0, msg) + + def no_mutable_default_args(logical_line): msg = "N301: Method's default argument shouldn't be mutable!" if mutable_default_args.match(logical_line): @@ -24,3 +37,4 @@ def no_mutable_default_args(logical_line): def factory(register): register(no_mutable_default_args) + register(no_log_warn) |