summaryrefslogtreecommitdiff
path: root/docker/swift
diff options
context:
space:
mode:
authorShaun Smekel <shaun.smekel@theorem.net.au>2016-08-12 08:24:11 +1000
committerPaul Bourke <paul.bourke@oracle.com>2016-08-19 10:49:03 +0000
commita9d08726f5a48eef77c04ea1acefc00d93ce7076 (patch)
tree73762d7fd4f9b95cba8fbefe273de9a9db8eabb7 /docker/swift
parent0b7e853784c2c0db115b0e72a3f7fc58c86c7660 (diff)
downloadkolla-a9d08726f5a48eef77c04ea1acefc00d93ce7076.tar.gz
kolla-a9d08726f5a48eef77c04ea1acefc00d93ce7076.zip
Handle empty package list for install_packages
Currently if the install_packages macro is run with an empty package list, it will add a yum or apt-get command with no packages listed. This bug fix aims to omit this line when no packages have been given, or, the operator wants to use the "_override" / "_remove" functionality to disable all packages being installed in a Dockerfile. Co-Authored-By: Paul Bourke <paul.bourke@oracle.com> Change-Id: Ifaaaebfccc3adb0f2f68a35ac08e59378bc87fdb Closes-bug: 1612446
Diffstat (limited to 'docker/swift')
-rw-r--r--docker/swift/swift-account/Dockerfile.j22
-rw-r--r--docker/swift/swift-base/Dockerfile.j24
-rw-r--r--docker/swift/swift-container/Dockerfile.j22
-rw-r--r--docker/swift/swift-object/Dockerfile.j22
-rw-r--r--docker/swift/swift-proxy-server/Dockerfile.j22
-rw-r--r--docker/swift/swift-rsyncd/Dockerfile.j22
6 files changed, 7 insertions, 7 deletions
diff --git a/docker/swift/swift-account/Dockerfile.j2 b/docker/swift/swift-account/Dockerfile.j2
index 6fd31431f..dacde88b0 100644
--- a/docker/swift/swift-account/Dockerfile.j2
+++ b/docker/swift/swift-account/Dockerfile.j2
@@ -10,7 +10,7 @@ MAINTAINER {{ maintainer }}
{% set swift_acount_packages = ['swift-account'] %}
{% endif %}
-RUN {{ macros.install_packages(swift_acount_packages | customizable("packages")) }}
+{{ macros.install_packages(swift_acount_packages | customizable("packages")) }}
{% endif %}
diff --git a/docker/swift/swift-base/Dockerfile.j2 b/docker/swift/swift-base/Dockerfile.j2
index 15bf9ee49..5fe04a0a2 100644
--- a/docker/swift/swift-base/Dockerfile.j2
+++ b/docker/swift/swift-base/Dockerfile.j2
@@ -10,7 +10,7 @@ MAINTAINER {{ maintainer }}
{% set swift_base_packages = ['swift'] %}
{% endif %}
-RUN {{ macros.install_packages(swift_base_packages | customizable("packages")) }}
+{{ macros.install_packages(swift_base_packages | customizable("packages")) }}
{% elif install_type == 'source' %}
{% if base_distro in ['centos', 'fedora', 'oraclelinux', 'rhel'] %}
@@ -19,7 +19,7 @@ RUN {{ macros.install_packages(swift_base_packages | customizable("packages")) }
{% set swift_base_packages = ['liberasurecode-dev'] %}
{% endif %}
-RUN {{ macros.install_packages(swift_base_packages | customizable("packages")) }}
+{{ macros.install_packages(swift_base_packages | customizable("packages")) }}
ADD swift-base-archive /swift-base-source
RUN ln -s swift-base-source/* swift \
&& useradd --user-group swift \
diff --git a/docker/swift/swift-container/Dockerfile.j2 b/docker/swift/swift-container/Dockerfile.j2
index cbce0c2bd..c59cac0e9 100644
--- a/docker/swift/swift-container/Dockerfile.j2
+++ b/docker/swift/swift-container/Dockerfile.j2
@@ -10,7 +10,7 @@ MAINTAINER {{ maintainer }}
{% set swift_container_packages = ['swift-container'] %}
{% endif %}
-RUN {{ macros.install_packages(swift_container_packages | customizable("packages")) }}
+{{ macros.install_packages(swift_container_packages | customizable("packages")) }}
{% endif %}
diff --git a/docker/swift/swift-object/Dockerfile.j2 b/docker/swift/swift-object/Dockerfile.j2
index e169f4de0..d575af047 100644
--- a/docker/swift/swift-object/Dockerfile.j2
+++ b/docker/swift/swift-object/Dockerfile.j2
@@ -10,7 +10,7 @@ MAINTAINER {{ maintainer }}
{% set swift_object_packages = ['swift-object'] %}
{% endif %}
-RUN {{ macros.install_packages(swift_object_packages | customizable("packages")) }}
+{{ macros.install_packages(swift_object_packages | customizable("packages")) }}
{% endif %}
diff --git a/docker/swift/swift-proxy-server/Dockerfile.j2 b/docker/swift/swift-proxy-server/Dockerfile.j2
index 6ba07b902..54895ff65 100644
--- a/docker/swift/swift-proxy-server/Dockerfile.j2
+++ b/docker/swift/swift-proxy-server/Dockerfile.j2
@@ -10,7 +10,7 @@ MAINTAINER {{ maintainer }}
{% set swift_proxy_server_packages = ['swift-proxy'] %}
{% endif %}
-RUN {{ macros.install_packages(swift_proxy_server_packages | customizable("packages")) }}
+{{ macros.install_packages(swift_proxy_server_packages | customizable("packages")) }}
{% endif %}
diff --git a/docker/swift/swift-rsyncd/Dockerfile.j2 b/docker/swift/swift-rsyncd/Dockerfile.j2
index 74864edef..b85a7a492 100644
--- a/docker/swift/swift-rsyncd/Dockerfile.j2
+++ b/docker/swift/swift-rsyncd/Dockerfile.j2
@@ -9,7 +9,7 @@ MAINTAINER {{ maintainer }}
{% set swift_rsyncd_packages = ['rsync'] %}
{% endif %}
-RUN {{ macros.install_packages(swift_rsyncd_packages | customizable("packages")) }}
+{{ macros.install_packages(swift_rsyncd_packages | customizable("packages")) }}
COPY extend_start.sh /usr/local/bin/kolla_extend_start
RUN chmod 755 /usr/local/bin/kolla_extend_start