summaryrefslogtreecommitdiff
path: root/docker/sahara
diff options
context:
space:
mode:
authorRadosław Piliszek <radoslaw.piliszek@gmail.com>2022-08-29 18:13:34 +0000
committerRadosław Piliszek <radoslaw.piliszek@gmail.com>2022-10-10 15:06:05 +0000
commit2daf4331a648cc2df6982c1a6ec47a705e038255 (patch)
tree9fe722152766faad365172b1ae442bf76453ef47 /docker/sahara
parentb8a352647d57d35463e551a0d360c19fb2ad34c6 (diff)
downloadkolla-2daf4331a648cc2df6982c1a6ec47a705e038255.tar.gz
kolla-2daf4331a648cc2df6982c1a6ec47a705e038255.zip
Fix writable rootwrap/privsep config
Fixes a hypothetical security issue related to privilege escalation via rootwrap/privsep. A potential vulnerable service could previously allow writes to its rootwrap/privsep config and thus allow for more commands to be run with root privileges via rootwrap/privsep. For a succesful attack, this would also require the service to allow to run arbitrary commands via rootwrap/privsep. Thus far, no such vulnerabilities have been reported and thus this fix is simply strengthening the container images against such an issue in the future. Change-Id: I92c81c77e6a16570a108cde8031f7977930fb02a Closes-Bug: #1874298
Diffstat (limited to 'docker/sahara')
-rw-r--r--docker/sahara/sahara-base/Dockerfile.j21
1 files changed, 0 insertions, 1 deletions
diff --git a/docker/sahara/sahara-base/Dockerfile.j2 b/docker/sahara/sahara-base/Dockerfile.j2
index af60f2022..713795444 100644
--- a/docker/sahara/sahara-base/Dockerfile.j2
+++ b/docker/sahara/sahara-base/Dockerfile.j2
@@ -36,7 +36,6 @@ RUN ln -s sahara-base-source/* sahara \
fi \
&& mkdir -p /etc/sahara \
&& cp -r /sahara/etc/sahara/* /etc/sahara/ \
- && chown -R sahara: /etc/sahara \
&& sed -i 's|^exec_dirs.*|exec_dirs=/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g' /etc/sahara/rootwrap.conf \
&& chmod 750 /etc/sudoers.d \
&& chmod 640 /etc/sudoers.d/kolla_sahara_sudoers \