openstack/kolla.git/tests/test_set_config.py, branch zed-eol

Add comprehensive checks for container restarts

2023-08-30T07:13:58+00:00

When adding a dashboard to grafana the containers aren't restarted when they should be. This is due to a bug in Kolla where the logic to determine whether or the container needs to be restarted fails in the case where the file does not exist in the container. This patch adds more comprehensive checks for container restarts in the set_configs.py file. This patch also adds a test to ensure that the functions work as expected. Closes-Bug: #1997984 Co-Authored-By: Will Szumski Change-Id: I67f5f12700d7b55f26bff81e9b54559303da6d83 (cherry picked from commit d9a6c5f3901e078a30d341397ac57d867d8191cc)

Fix CVE-2022-38060

2022-08-29T10:05:05+00:00

Closes-Bug: #1985784 Change-Id: I66476a2b396e2cbe41e68ac51f57aae1806b2ed8

Make kolla_set_configs open files in binary mode

2021-02-10T14:57:58+00:00

This fixes comparisons when files are not Unicode-encoded. A relevant unit test is included. It can be used as a base for other _cmp_file method unit tests if the need arises. Change-Id: Ic638516eb92d24ad247a7866fd1b5e2ac0400388 Closes-Bug: #1913952

Remove two missed unicode flags

2021-01-25T14:58:59+00:00

Change-Id: I799bf8edfef6ff68382d651dca6de96fa80ed733

Update imp module to importlib

2020-08-30T14:11:52+00:00

The imp module is deprecated[1] since version 3.4, use importlib to instead 1: https://docs.python.org/3/library/imp.html Change-Id: I79dfd923531dd3e00d23e1682865f56f0cf437d2

Fix kolla_set_configs --check with a directory

2020-08-28T15:01:25+00:00

There are several issues with kolla_set_configs --check: 1. We calculate the destination path incorrectly when comparing a file in a directory, due to passing arguments to os.path.relpath in the wrong order 2. For directories that have not changed, we also attempt to compare them as files, which fails when they are open()ed. 3. If the config JSON does not have a config_files key, it fails with a KeyError. The first two issues affect the fluentd container, which specifies directories as the source, without using a glob. The third affects OVN containers. This patch fixes these issues. Closes-Bug: #1890567 Change-Id: I8921befe51da4282121443849177a7ca5ebe8822

Merge "Update hacking for Python3"

2020-04-03T20:03:12+00:00

Use unittest.mock instead of PyPI mock

2020-04-02T16:22:38+00:00

Now that py2 is gone, oslotest dropped dependency on mock and will soon affect Ussuri CI [1], let's use unittest.mock built in py3. This also fixes py38 jobs and proactively prevents py36 and py37 failing due to [1]. This is because we never included mock in test-requirements (but in lower-constraints where it does not really belong at all) and instead relied on oslotest to bring it in. [1] https://review.opendev.org/716322 Change-Id: Iceedcc7ad0d087414f6f94dfc0235fda4754be63

Update hacking for Python3

2020-04-01T19:42:41+00:00

The repo is Python 3 now, so update hacking to version 3.0 which supports Python 3. Fix problems found by updated hacking version. Update local hacking checks for new flake8. Remove hacking and friends from lower-constraints, they are not needed in installations. Change-Id: I67e5ca24c550163c218fb06692de0b7c528d8318

Make set_configs.py work with symlinks

2017-07-06T09:18:53+00:00

Closes-Bug: #1702305 Change-Id: I92a404b8d301937dc1847d42576e30db43951990