openstack/kolla.git/tests/test_set_config.py, branch stable/2026.2

Migrate to pyproject.toml

2026-07-06T19:59:40+00:00

[tool.setuptools.data-files] does not support recursive directory installation. The old setup.cfg [files] worked because PBR's FilesConfig.expand_globs() used os.walk() to expand docker/*, but this hook is not triggered by the pbr.build PEP-517 backend. Move docker/ into kolla/ and use [tool.setuptools.package-data] instead. Update kolla_worker._get_images_dir() to check the kolla package directory first so both editable and regular installs work. Change-Id: I4fc452c03740ef22ebbb4e8d0d86c4f4783e2d09 Signed-off-by: Michal Nasiadka

Merge "Remove redundant permission parsing tests"

2026-07-04T08:11:01+00:00

set_configs: Add support for creating files and setting perms

2026-07-02T15:28:39+00:00

Change-Id: I74a6d05007488b69fa040c40d01a07afae369794 Needed-By: https://review.opendev.org/c/openstack/kolla-ansible/+/989850 Signed-off-by: Michal Arbet

Remove redundant permission parsing tests

2026-07-02T14:25:33+00:00

The removed Python octal notation test is already covered by test_handle_permissions_accepts_valid_permission_notations, which includes 0o2775. Change-Id: Ia25d10a6ff3608e2a38d1a88bf229fe3f96d19ee Signed-off-by: Michal Arbet

Fix parsing of permissions with special bits

2026-07-01T16:11:49+00:00

kolla_set_configs currently fails to parse permissions such as 2775 because only legacy values like 0755 are converted to Python octal notation. Accept standard UNIX permission notation for permissions with special mode bits such as SGID, SUID, and sticky bit. Change-Id: I5937a17b0d70f9c1db4b2617854d0180c37fe2c0 Closes-Bug: #2154269 Needed-By: https://review.opendev.org/c/openstack/kolla-ansible/+/989850 Signed-off-by: Michal Arbet

Add YAML support to kolla_set_configs engine

2026-06-17T16:32:01+00:00

Following the PTG agreement, this commit extends the container configuration engine (set_configs.py) to support YAML format while maintaining backward compatibility with JSON. - Integrated 'yaml' library as a universal parser for both JSON and YAML formats (YAML is a superset of JSON) - Updated 'load_config' to search for 'config.json', 'config.yaml' - Added 'python3-yaml' (Debian) and 'python3-pyyaml' (RHEL) as required base packages in Dockerfile.j2 This change improves configuration readability and allows for easier maintenance while ensuring no breakage for existing JSON-based deployments. Change-Id: Icfb52b8f94e1036d5952b160c5921348d1427fda Signed-off-by: Piotr Milewski

set_configs: Add support for creating directories and setting perms

2026-05-05T10:34:26+00:00

Change-Id: Id63c035fafaa68a9004c65161c5a3a3ad5544f02 Signed-off-by: Michal Nasiadka

Fix kolla-set-configs --check to detect state mismatch

2025-06-19T12:23:35+00:00

If a configuration file is tracked in the state file but no longer appears in config.json, it should either be restored or removed. This patch introduces a new exception StateMismatch and updates execute_config_check() to detect such cases. If any destination path is present in the defaults state but missing from config.json, we now raise StateMismatch. A dedicated unit test has been added to verify this behavior. Closes-Bug: #2114173 Signed-off-by: Michal Arbet Change-Id: I6e0b4aaa5722990e3ac647578023f474db3d4381

Fix mock_open() expectations for Python 3.13+

2025-05-21T12:58:57+00:00

Python 3.13 introduces a behavior change in unittest.mock.mock_open(), which now calls close() when exiting the context manager as described in bpo-44185 [1]. This causes additional mock calls to appear, breaking strict mock_calls assertions. This patch fix tests and add compatibility for Python 3.13. From mock documentation [2]: "bpo-44185: unittest.mock.mock_open() will call the close() method of the file handle mock when it is exiting from the context manager. Patch by Samet Yaslan." [1] https://bugs.python.org/issue44185 [2] https://mock.readthedocs.io/en/latest/changelog.html Change-Id: Ib8e2a8a20a828c4c69deedd307c9b726f51489f8

Fix handling configs in base image

2024-11-06T16:37:31+00:00

This commit restructures the handling of configuration files in set_configs.py, introducing functions for managing default configuration files first. Closes-Bug: #2060855 Change-Id: If91e0330dc149143c82d2183b8ddf6fa9f68d80e