From bfbf1b8c9b3a0abba86474aeb72b950142723d73 Mon Sep 17 00:00:00 2001 From: Lars Kellogg-Stedman Date: Tue, 14 Oct 2014 12:17:47 -0400 Subject: add better validation checks (part 1) This patch adds a script for validating YAML files, and replaces the existing JSON checks with one largely identical to the YAML check. This also provides a script that can be installed as a pre-commit hook that will perform this checks when you commit changes. You can install the hook by running tools/pre-commit-hook --install. Change-Id: Ib4742a9db062362cfa61d669c691151bc1ca376c --- tools/pre-commit-hook | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100755 tools/pre-commit-hook (limited to 'tools/pre-commit-hook') diff --git a/tools/pre-commit-hook b/tools/pre-commit-hook new file mode 100755 index 000000000..699cb978e --- /dev/null +++ b/tools/pre-commit-hook @@ -0,0 +1,45 @@ +#!/bin/sh + +TOPLEVEL=$(git rev-parse --show-toplevel) +RES=0 + +cd $TOPLEVEL + +if [ "$1" == "--install" ]; then + ln -sf ../../tools/pre-commit-hook .git/hooks/pre-commit + exit +fi + +tmpdir=$(mktemp -d precommit.XXXXXX) || exit 1 +trap "rm -rf $TOPLEVEL/$tmpdir" 0 + +git diff --cached --name-only --diff-filter=ACMR | + xargs git checkout-index --prefix=$tmpdir/ -- + +cd $tmpdir + +echo "=== starting pre-commit checks ===" + +echo "Checking the following files:" + +find . -type f + +echo "=== bashate checks ===" + +find . -type f -print0 | + xargs -0 --no-run-if-empty egrep -lZ '^#!/bin/(ba)?sh' | + xargs -0 bashate || RES=1 + +echo "=== yaml checks ===" + +find . -name '*.yaml' -print0 | + xargs -0 --no-run-if-empty python ${TOPLEVEL}/tools/try-parse-yaml.py + +echo "=== json checks ===" + +find . -name '*.json' -print0 | + xargs -0 -n1 --no-run-if-empty python -mjson.tool \ + || RES=1 + +exit $RES + -- cgit v1.2.3