From c8ea844b2b31cfc0446b6174e6b033a4036b9750 Mon Sep 17 00:00:00 2001 From: Michal Nasiadka Date: Wed, 7 Jan 2026 11:10:37 +0100 Subject: ansible-lint: Rework validate-all-file into custom rules Test roles/ subdirectories as well (used by Zuul) In addition to that container_exec_become will also fail when "docker exec" or "podman exec" will be used instead of "{{ kolla_container_engine }} exec" Generated-By: Claude Change-Id: I75c1e48c36bb0284e2927b1cb354ce9ec47967d7 Signed-off-by: Michal Nasiadka --- roles/multi-node-managed-addressing/tasks/main.yml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'roles/multi-node-managed-addressing') diff --git a/roles/multi-node-managed-addressing/tasks/main.yml b/roles/multi-node-managed-addressing/tasks/main.yml index dcf189905..925468b8b 100644 --- a/roles/multi-node-managed-addressing/tasks/main.yml +++ b/roles/multi-node-managed-addressing/tasks/main.yml @@ -21,13 +21,17 @@ # broadcast address as ansible picks up scope ('global') as the interface's # broadcast address which fails checks logic managed_network_broadcast_address: "{{ managed_network_cidr | ansible.utils.ipaddr('broadcast') }}" - command: ip address add {{ managed_network_cidr }} broadcast {{ managed_network_broadcast_address }} dev {{ managed_interface_name }} + ansible.builtin.command: + cmd: ip address add {{ managed_network_cidr }} broadcast {{ managed_network_broadcast_address }} dev {{ managed_interface_name }} + changed_when: true when: managed_network_address_family == 'ipv4' # NOTE(yoctozepto): IPv6 has no broadcast address, let's not create confusion by setting it - name: Add IPv6 address for managed network become: true - command: ip address add {{ managed_interface_address }}/{{ managed_network_prefix_length }} dev {{ managed_interface_name }} + ansible.builtin.command: + cmd: ip address add {{ managed_interface_address }}/{{ managed_network_prefix_length }} dev {{ managed_interface_name }} + changed_when: true when: managed_network_address_family == 'ipv6' - name: Accept traffic on the managed network (IN) @@ -57,7 +61,9 @@ # hence we only check whether it's no longer tentative - name: Ensure IPv6 addresses on the managed interface are no longer tentative become: true - command: ip -o address show tentative dev {{ managed_interface_name }} + ansible.builtin.command: + cmd: ip -o address show tentative dev {{ managed_interface_name }} + changed_when: false register: tentative_addresses until: tentative_addresses.stdout == '' retries: 30 @@ -69,5 +75,7 @@ become: true vars: ping_command: "{{ 'ping' if managed_network_address_family == 'ipv4' else 'ping6' }}" - command: "{{ ping_command }} -c1 {{ hostvars[item].managed_interface_address }}" + ansible.builtin.command: + cmd: "{{ ping_command }} -c1 {{ hostvars[item].managed_interface_address }}" + changed_when: false with_inventory_hostnames: all -- cgit v1.2.3