From ade5bfa302f131cf1111a61ec95c6cddc3827e04 Mon Sep 17 00:00:00 2001 From: Mark Goddard Date: Thu, 13 May 2021 12:21:11 +0100 Subject: Use ansible_facts to reference facts By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts.. This change updates all references to Ansible facts within Kolla Ansible from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement. This change disables fact variable injection in the ansible configuration used in CI, to catch any attempts to use the injected variables. [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars Change-Id: I7e9d5c9b8b9164d4aee3abb4e37c8f28d98ff5d1 Partially-Implements: blueprint performance-improvements --- kolla_ansible/kolla_address.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'kolla_ansible/kolla_address.py') diff --git a/kolla_ansible/kolla_address.py b/kolla_ansible/kolla_address.py index 888ee734c..f40b59f6a 100644 --- a/kolla_ansible/kolla_address.py +++ b/kolla_ansible/kolla_address.py @@ -82,7 +82,7 @@ def kolla_address(context, network_name, hostname=None): network_name=network_name)) ansible_interface_name = interface_name.replace('-', '_') - interface = host.get('ansible_' + ansible_interface_name) + interface = host['ansible_facts'].get(ansible_interface_name) if interface is None: raise FilterError("Interface '{interface_name}' " "not present " -- cgit v1.2.3