From 9b3428c5046ec5032585bd6ea9baa50da3d82a4b Mon Sep 17 00:00:00 2001 From: Will Szumski Date: Fri, 23 Feb 2024 17:06:51 +0000 Subject: Support mode in named volumes when using podman Volumes with a mode specifier were causing the container to fail to start with the error: "Wrong format of volume". ironic-dnsmasq was one services affected by this issue, but you could also hit this issue when using the volume customisation variables. Closes-Bug: #2054834 Change-Id: I848bd2838a17756f1c71b07befe1e3d966f5b6c2 --- ansible/module_utils/kolla_podman_worker.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'ansible/module_utils') diff --git a/ansible/module_utils/kolla_podman_worker.py b/ansible/module_utils/kolla_podman_worker.py index dd215174e..e0aee7bd5 100644 --- a/ansible/module_utils/kolla_podman_worker.py +++ b/ansible/module_utils/kolla_podman_worker.py @@ -176,7 +176,11 @@ class PodmanWorker(ContainerWorker): mounts.append(mount_item) else: try: - src, dest = item.split(':') + mode = 'rw' + if item.count(':') == 2: + src, dest, mode = item.split(':') + else: + src, dest = item.split(':') except ValueError: self.module.fail_json( msg="Wrong format of volume: {}".format(item), @@ -191,7 +195,7 @@ class PodmanWorker(ContainerWorker): else: filtered_volumes[src] = dict( bind=dest, - mode='rw' + mode=mode ) def parse_dimensions(self, dimensions): -- cgit v1.2.3