From 68c9cba6c12cb37863c843bb7eb6fd9a3cc54db3 Mon Sep 17 00:00:00 2001 From: Michal Nasiadka Date: Tue, 25 Nov 2025 07:51:16 +0100 Subject: ansible-lint: Fix command-instead-of-module/shell Change-Id: I4099b338b0d16bedf5731a3a63eeaad27a321d9b Signed-off-by: Michal Nasiadka --- .ansible-lint | 2 -- ansible/roles/loadbalancer/tasks/config_validate.yml | 2 +- ansible/roles/valkey/tasks/check.yml | 2 +- ansible/roles/valkey/tasks/upgrade.yml | 4 ++-- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.ansible-lint b/.ansible-lint index 8a566c133..5c0c0640a 100644 --- a/.ansible-lint +++ b/.ansible-lint @@ -37,6 +37,4 @@ skip_list: - var-naming[no-role-prefix] - risky-file-permissions - risky-shell-pipe - - command-instead-of-shell - - command-instead-of-module - yaml[line-length] diff --git a/ansible/roles/loadbalancer/tasks/config_validate.yml b/ansible/roles/loadbalancer/tasks/config_validate.yml index cfb336919..acb6f9912 100644 --- a/ansible/roles/loadbalancer/tasks/config_validate.yml +++ b/ansible/roles/loadbalancer/tasks/config_validate.yml @@ -2,7 +2,7 @@ - name: Validating haproxy config files vars: service: "{{ loadbalancer_services['haproxy'] }}" - shell: >- + command: >- {{ kolla_container_engine }} exec -i haproxy haproxy -c -f /etc/haproxy/haproxy.cfg -f /etc/haproxy/services.d/ register: haproxy_config_validation_result diff --git a/ansible/roles/valkey/tasks/check.yml b/ansible/roles/valkey/tasks/check.yml index d7531527a..1e3c86362 100644 --- a/ansible/roles/valkey/tasks/check.yml +++ b/ansible/roles/valkey/tasks/check.yml @@ -5,7 +5,7 @@ - name: Valkey ping pong check become: true - shell: >- + command: >- {{ kolla_container_engine }} exec valkey_server valkey-cli -h {{ api_interface_address }} -a {{ valkey_master_password }} ping register: valkey_check diff --git a/ansible/roles/valkey/tasks/upgrade.yml b/ansible/roles/valkey/tasks/upgrade.yml index 0de57486a..5a7499ded 100644 --- a/ansible/roles/valkey/tasks/upgrade.yml +++ b/ansible/roles/valkey/tasks/upgrade.yml @@ -36,7 +36,7 @@ become: true delegate_to: "{{ valkey_master_host }}" run_once: true - shell: >- + command: >- {{ kolla_container_engine }} exec valkey_server valkey-cli -h {{ api_interface_address }} -p {{ valkey_server_port }} info replication register: valkey_replication @@ -81,7 +81,7 @@ become: true delegate_to: "{{ valkey_master_host }}" run_once: true - shell: >- + command: >- {{ kolla_container_engine }} exec valkey_server valkey-cli -h {{ api_interface_address }} -p {{ valkey_server_port }} info replication register: valkey_role -- cgit v1.2.3