aboutsummaryrefslogtreecommitdiff
path: root/.ansible-lint
AgeCommit message (Collapse)AuthorFilesLines
2026-03-24ansible-lint: Disable comment checks in etc/kolla/globals.ymlMichal Nasiadka1-1/+1
Restore strictness of check, because we stop using .ansible-lint-ignore file. Change-Id: Ia5e80d96efc27e4deb4402bd89df7e58d9b5ca82 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2026-03-24ansible-lint: Fix fqcn[actions]Michal Nasiadka1-2/+0
Change-Id: I3f9e5aada1059d882d2013e0721c10708f43d1cf Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2026-03-19ansible-lint: Fix fqcn[actions-core] in playbooksMichal Nasiadka1-3/+0
Also add all failed roles into ignore and these will be removed in subsequent patches Change-Id: Ifa6f2725cfa93cb14d72daf27448bd58f186acfd Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2026-03-13ansible-lint: remove line-length skipBertrand Lanson1-1/+0
Change-Id: I5e4b3740499ddedf43f647ede4d37a619eebe61a Signed-off-by: Bertrand Lanson <bertrand.lanson@infomaniak.com>
2026-01-09ansible-lint: Rework validate-all-file into custom rulesMichal Nasiadka1-2/+6
Test roles/ subdirectories as well (used by Zuul) In addition to that container_exec_become will also fail when "docker exec" or "podman exec" will be used instead of "{{ kolla_container_engine }} exec" Generated-By: Claude Change-Id: I75c1e48c36bb0284e2927b1cb354ce9ec47967d7 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-12-10ansible-lint: remove unnamed-task from skip_listBertrand Lanson1-3/+0
Change-Id: I481734d34919b6e723f4540165115ff7e8938694 Signed-off-by: Bertrand Lanson <bertrand.lanson@protonmail.com>
2025-12-05ansible-lint: Fix name[play]Michal Nasiadka1-2/+0
Change-Id: I82310a2ebfa326a01424c7469d4eb9d440dc9b9c Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-12-04ansible-lint: Fix name[template], remove package-latestMichal Nasiadka1-4/+0
Change-Id: I7c693403b1768c6c97eea90c3dfe9326764c3230 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-12-04Merge "ansible-lint: Remove no-tabs from skip list"Zuul1-2/+0
2025-12-04Merge "ansible-lint: Add noqa to existing no-handler violations"Zuul1-2/+0
2025-12-04Merge "ansible-lint: Fix no-changed-when"Zuul1-3/+0
2025-12-04Merge "ansible-lint: Fix risky-*"Zuul1-2/+0
2025-12-04ansible-lint: Remove no-tabs from skip listMichal Nasiadka1-2/+0
Change-Id: I7b9ddcd7116de41b6d968365736bcd9301aa9fb9 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-12-04ansible-lint: Add noqa to existing no-handler violationsMichal Nasiadka1-2/+0
Change-Id: Ifc788b1f3f4fee23745e4a88bba208ff21366263 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-12-04ansible-lint: Fix no-changed-whenMichal Nasiadka1-3/+0
Change-Id: I676f8d3c4cc446d7dd65239c0363e4d362662b0d Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-12-04ansible-lint: Fix risky-*Michal Nasiadka1-2/+0
Change-Id: I3914252b2d884349b9744d229406cf49d691ebec Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-12-03ansible-lint: Remove role-name exceptionMichal Nasiadka1-2/+0
Change-Id: I4f021289faa790b733d95532f6d837c3f724cf0b Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-11-28ansible-lint: Fix command-instead-of-module/shellMichal Nasiadka1-2/+0
Change-Id: I4099b338b0d16bedf5731a3a63eeaad27a321d9b Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-11-28ansible-lint: Remove yaml[truthy] from excludesMichal Nasiadka1-3/+4
Normalize quotes and some other easy fixes done by ansible-lint --fix Also drop etc from excludes and ignore comment check in etc/kolla/globals.yml Pinning to ansible-lint<25.11.0 because 25.11.1 is breaking without any messages Change-Id: I7dee3866191cef84cd12b1816cdab0a02380ec7f Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-11-17ansible-lint: Remove ignore-errors from excludesMichal Nasiadka1-1/+0
Change-Id: I87a5b312de28c37c21cd73920a681b7e9e603b30 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-11-17ansible-lint: Remove no-free-form from excludesMichal Nasiadka1-1/+0
Change-Id: I58d00089e01953a1b8e2d2ba20c5a7e300ca30b9 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-11-17ansible-lint: Remove key-order[task] excludeMichal Nasiadka1-1/+0
Change-Id: I77cce57f3f2b05455e8bd4e7093081ef4ed25d59 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-11-08Merge "ansible-lint: Fix jinja[spacing]"Zuul1-1/+0
2025-11-08Merge "ansible-lint: Fix yaml[octal-values]"Zuul1-1/+0
2025-11-06ansible-lint: Fix jinja[spacing]Michal Nasiadka1-1/+0
Change-Id: I2e30c04bd1597ec15e4c681b31443c7886154194 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-11-06CI: ansible-lint: Move exclude paths to .ansible-lintMichal Nasiadka1-0/+5
Change-Id: Ide4387d3a041ee424bc7f62fb4ddb38ff3e7cb52 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-11-06ansible-lint: Fix yaml[octal-values]Michal Nasiadka1-1/+0
Change-Id: I0c55f924489657ddcdb2957070cd69563c6d9886 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
2025-06-04CI: Bump ansible-lint to <26Michal Nasiadka1-0/+3
Remove yamllint usage - it duplicates what reno lint/ansible-lint do. Change-Id: If8ad229281b2dca565570d651065779c2c871528
2024-01-22Bump ansible-lint versionMichal Arbet1-0/+11
The version that we were capping to is no longer compatible with latest upper-constraints.txt, so let us free float again. The resulting linting errors are included for now to unblock the gate, these will still need to be discussed or fixed later. NOTE(kevko): Temporarily disabling horizon deployment, as it's not possible to unblock gates without it Co-Authored-By: Michal Arbet <michal.arbet@ultimum.io> Change-Id: Ib7f72b2663199ef80844a412bc436c6ef09322cc
2023-12-19CI: treat ansible-lint warnings as errorsMichal Nasiadka1-0/+1
Taken from [1]. [1]: https://ansible.readthedocs.io/projects/lint/configuring/#ansible-lint-configuration Change-Id: I29c1abb4d518a4da6788e06804f28c5f6853c581
2022-10-12Skip ansible-lint fqcn for module actions and role-nameMichal Nasiadka1-0/+4
Add noqa for: Object of type PosixPath is not JSON serializable Change-Id: Id6ef88bb8cd16120bf31da679d1129d99f4b9fd8
2022-09-26ansible-lint: cleanup our skip listMarcin Juszkiewicz1-12/+2
removed: - 701 [galaxy_info missing] is no longer emited - 602 [empty string compare] is now opt-in - 208 [permissions not mentioned] is no longer emited - 106 [role name] is no longer emited renamed from number to role name: - 503 [no-handler] - 301 [no-changed-when] Change-Id: I8b059d87c94499decbd9b115ef2cde033aa88fbd
2022-09-26CI: allow Jinja templating anywhere inside task and play namesPierre Riteau1-0/+2
With the release of ansible-lint 6.7.0, the openstack-tox-linters job started failing with these errors: WARNING Listing 30 violation(s) that are fatal ansible/roles/ceilometer/tasks/config.yml:66: name: Jinja templates should only be at the end of 'name' (name[template]) [...] Add this new check to skip_list for now. Change-Id: Ia82a88ee3b9bb6a3cb09f09c6568d1914ee2592d
2022-04-12Bump ansible-lint version to 6.*Dr. Jens Harbott1-0/+3
Add fqcn-builtins to the skip list for now, we will watch how the discussion about this evolves and defer updating all code according to that [0]. [0] https://github.com/ansible/ansible-lint/issues/2050 Signed-off-by: Dr. Jens Harbott <harbott@osism.tech> Change-Id: I6dcdec4f029b87bad41530ad45d285909c8351f7
2022-02-15CI: Fix new ansible-lint failuresMichal Nasiadka1-0/+6
Change-Id: I27b0e42fba93a35c6d878d108bf1e7fdebc9e3db
2021-03-19CI: Fix yamllint comments-indentation in .ansible-lintMichał Nasiadka1-11/+12
Change-Id: Ie3ca5526e2af30db06631e7c215fe2db13c92f2f
2021-03-11ansible-lint: add unnamed-task to the skip listMark Goddard1-0/+3
The 5.0.3 release of ansible-lint makes the linters job fail, due to the addition of an unnamed-task rule. We have quite a large number of unnamed tasks, typically include_tasks or include_role. We may want to address this at some point, but not right now. Change-Id: I4ee706fe2463d62e4e16412117d4373748ea43e3
2020-08-21[TrivialFix] Clean a recent commentRadosław Piliszek1-1/+1
Change-Id: Ic58a27e517004768433a1e793d4d8e90e2c3383a
2020-08-21Fix ansible-lint after upgrade to 4.3.1Michal Nasiadka1-1/+6
Change-Id: I3a31c74608b48919c1563bac88313a8c4219dedc Co-Authored-By: Radosław Piliszek <radoslaw.piliszek@gmail.com>
2020-05-17CI: Add ansible-lint to toxMichal Nasiadka1-0/+12
* Reworked tox pep8 into linters job, that runs: - pep8 - bandit - bashate - doc8 - yamllint - ansible-lint (validate-all-files.py + ansible-lint) * Skip E701 - missing galaxy_info in meta and E602 see [1]. * Skip E301 and E503 - followup later in a separate change * Added ansible-role-jobs to zuul.d/project.yaml which will run openstack-tox-linters job in check queue * Fixed remaining style issue * Made tox and docs reference the new env for linters * Dropped pype environment (not supported) [1]: https://github.com/ansible/ansible-lint/issues/457 Change-Id: I494b4b151804aac8173120e6c6e42bc2fdb00234