aboutsummaryrefslogtreecommitdiff
path: root/tools/run-bashate.sh
diff options
context:
space:
mode:
authorRadosław Piliszek <radoslaw.piliszek@gmail.com>2020-04-24 15:57:55 +0200
committerRadosław Piliszek <radoslaw.piliszek@gmail.com>2020-04-24 15:57:55 +0200
commit3036c7cfda0a6ef01f7eb3ac25c70ba2cddb2f23 (patch)
treebc4bf932706ea2e1ad16c86329ddc07e2d339864 /tools/run-bashate.sh
parent9251315b36e3aad4aa9f0bcee3d239105eb7abd3 (diff)
downloadkolla-ansible-3036c7cfda0a6ef01f7eb3ac25c70ba2cddb2f23.tar.gz
kolla-ansible-3036c7cfda0a6ef01f7eb3ac25c70ba2cddb2f23.zip
CI: Make bashate happy
Bashate warned on init-swift.sh because of E043 -- arithmetic compound has inconsistent return semantics: (( next_port++ )) New Zuul reported that on every change as a warning. This is fixed here. This change makes Bashate always produce errors so that we do not introduce such warnings again. Change-Id: I40166b377ec2580e17901375b636183bca492d3a
Diffstat (limited to 'tools/run-bashate.sh')
-rwxr-xr-xtools/run-bashate.sh5
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/run-bashate.sh b/tools/run-bashate.sh
index 897228c81..2a92e960b 100755
--- a/tools/run-bashate.sh
+++ b/tools/run-bashate.sh
@@ -1,7 +1,10 @@
#!/bin/bash
# Ignore E006 -- line length greater than 80 char
+# Error on E005 -- file does not begin with #! or have .sh prefix
+# Error on E042 -- local declaration hides errors
+# Error on E043 -- arithmetic compound has inconsistent return semantics
ROOT=$(readlink -fn $(dirname $0)/.. )
find $ROOT -not -wholename \*.tox/\* -and -not -wholename \*.test/\* \
- -and -name \*.sh -print0 | xargs -0 bashate -v --ignore E006
+ -and -name \*.sh -print0 | xargs -0 bashate -v --ignore E006 --error E005,E042,E043