diff options
| author | Mark Goddard <mark@stackhpc.com> | 2024-02-29 10:48:40 +0000 |
|---|---|---|
| committer | Mark Goddard <mark@stackhpc.com> | 2024-05-16 11:32:47 +0100 |
| commit | 9cebdb5d9eb46b5ae28a52ef86e5bb50342c3648 (patch) | |
| tree | a5e905480a6d14e67ffddc36e47b4469cf8277e4 /tests/templates | |
| parent | b8146efd1c671971028cac85942e06c5ab8890c5 (diff) | |
| download | kolla-ansible-9cebdb5d9eb46b5ae28a52ef86e5bb50342c3648.tar.gz kolla-ansible-9cebdb5d9eb46b5ae28a52ef86e5bb50342c3648.zip | |
Revert "Allow setting any_errors_fatal true for gather-facts"
This reverts commit 5b431f0f7f932293362a01703673ee05d0a5bd8d.
Reason for revert: the any_errors_fatal play parameter is not templated
by Ansible (tested up to ansible-core 2.15.9). This behaviour is
demonstrated in [1].
This means that "{{ kolla_ansible_setup_any_errors_fatal }}" is always
interpreted as 'true', regardless of the value of
kolla_ansible_setup_any_errors_fatal. This is particularly bad because
the default value of kolla_ansible_setup_any_errors_fatal is false.
We now have gather_facts_max_fail_percentage which can be set to 0 to
provide the same functionality.
[1] https://github.com/markgoddard/ansible-experiments/tree/master/15-fatal-errors
Change-Id: I2e0ea49701b5900eae26434bcdb6b1bb44507ee7
Diffstat (limited to 'tests/templates')
| -rw-r--r-- | tests/templates/globals-default.j2 | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/tests/templates/globals-default.j2 b/tests/templates/globals-default.j2 index e03e103d9..2301bb01d 100644 --- a/tests/templates/globals-default.j2 +++ b/tests/templates/globals-default.j2 @@ -5,10 +5,6 @@ ansible_python_interpreter: /usr/bin/python3 {% endif %} -# NOTE(yoctozepto): In CI it makes sense to always try to fail -# as early as possible. -kolla_ansible_setup_any_errors_fatal: true - kolla_base_distro: "{{ base_distro }}" network_interface: "{{ api_interface_name }}" network_address_family: "{{ address_family }}" |