diff options
| author | Michal Nasiadka <mnasiadka@gmail.com> | 2026-01-07 11:10:37 +0100 |
|---|---|---|
| committer | Michal Nasiadka <mnasiadka@gmail.com> | 2026-01-09 08:34:19 +0000 |
| commit | c8ea844b2b31cfc0446b6174e6b033a4036b9750 (patch) | |
| tree | 29d2ef8215f7b7b5a426ff6e34bfdcc160bcd542 /roles/kolla-ansible-deploy | |
| parent | 7d89d6afbef6fcb352c30f9fe04a72fbeca1f18f (diff) | |
| download | kolla-ansible-c8ea844b2b31cfc0446b6174e6b033a4036b9750.tar.gz kolla-ansible-c8ea844b2b31cfc0446b6174e6b033a4036b9750.zip | |
ansible-lint: Rework validate-all-file into custom rules
Test roles/ subdirectories as well (used by Zuul)
In addition to that container_exec_become will also
fail when "docker exec" or "podman exec" will be used
instead of "{{ kolla_container_engine }} exec"
Generated-By: Claude
Change-Id: I75c1e48c36bb0284e2927b1cb354ce9ec47967d7
Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
Diffstat (limited to 'roles/kolla-ansible-deploy')
| -rw-r--r-- | roles/kolla-ansible-deploy/tasks/certificates.yml | 3 | ||||
| -rw-r--r-- | roles/kolla-ansible-deploy/tasks/deploy.yml | 6 | ||||
| -rw-r--r-- | roles/kolla-ansible-deploy/tasks/main.yml | 7 |
3 files changed, 14 insertions, 2 deletions
diff --git a/roles/kolla-ansible-deploy/tasks/certificates.yml b/roles/kolla-ansible-deploy/tasks/certificates.yml index 6296a1dbe..42910bc67 100644 --- a/roles/kolla-ansible-deploy/tasks/certificates.yml +++ b/roles/kolla-ansible-deploy/tasks/certificates.yml @@ -7,6 +7,7 @@ -i /etc/kolla/inventory -vvv >/tmp/logs/ansible/certificates 2>&1 + changed_when: true - name: Init pebble when Lets Encrypt is enabled when: (le_enabled | default(False)) | bool @@ -30,10 +31,12 @@ become: true ansible.builtin.command: cmd: "docker cp pebble:/test/certs/pebble.minica.pem /etc/kolla/certificates/ca/pebble-root.crt" + changed_when: true - name: "Fetch pebble.crt and store it in /etc/kolla/certificates/ca/" become: true ansible.builtin.get_url: url: "https://127.0.0.1:15000/roots/0" dest: "/etc/kolla/certificates/ca/pebble.crt" + mode: "0644" validate_certs: false diff --git a/roles/kolla-ansible-deploy/tasks/deploy.yml b/roles/kolla-ansible-deploy/tasks/deploy.yml index 771006735..eb7637bd4 100644 --- a/roles/kolla-ansible-deploy/tasks/deploy.yml +++ b/roles/kolla-ansible-deploy/tasks/deploy.yml @@ -7,6 +7,7 @@ -i /etc/kolla/inventory -vvv >/tmp/logs/ansible/deploy-prechecks 2>&1 + changed_when: false - name: Run kolla-ansible pull ansible.builtin.shell: @@ -16,6 +17,7 @@ -i /etc/kolla/inventory -vvv >/tmp/logs/ansible/pull 2>&1 + changed_when: true - name: Run kolla-ansible deploy ansible.builtin.shell: @@ -25,6 +27,7 @@ -i /etc/kolla/inventory -vvv >/tmp/logs/ansible/deploy 2>&1 + changed_when: true - name: Run kolla-ansible post-deploy ansible.builtin.shell: @@ -34,6 +37,7 @@ -i /etc/kolla/inventory -vvv >/tmp/logs/ansible/post-deploy 2>&1 + changed_when: true - name: Run kolla-ansible validate-config ansible.builtin.shell: @@ -43,6 +47,7 @@ -i /etc/kolla/inventory -vvv >/tmp/logs/ansible/validate-config 2>&1 + changed_when: false when: not is_upgrade | bool - name: Run kolla-ansible check @@ -53,3 +58,4 @@ -i /etc/kolla/inventory -vvv >/tmp/logs/ansible/check 2>&1 + changed_when: false diff --git a/roles/kolla-ansible-deploy/tasks/main.yml b/roles/kolla-ansible-deploy/tasks/main.yml index e02765d99..b2ec759cc 100644 --- a/roles/kolla-ansible-deploy/tasks/main.yml +++ b/roles/kolla-ansible-deploy/tasks/main.yml @@ -7,5 +7,8 @@ mode: "0777" recurse: true -- import_tasks: certificates.yml -- import_tasks: deploy.yml +- name: Import certificates.yml + import_tasks: certificates.yml + +- name: Import deploy.yml + import_tasks: deploy.yml |