aboutsummaryrefslogtreecommitdiff
path: root/deploy-guide
diff options
context:
space:
mode:
authorAlex Welsh <alex@stackhpc.com>2026-09-01 14:19:17 +0100
committerAlex Welsh <alex@stackhpc.com>2026-09-03 10:37:04 +0000
commita3badc9325e53d875b30f3b89947e7e2e2863781 (patch)
tree3b514f9d57c9cd5d85a53d019fccf2a78bbba097 /deploy-guide
parent0848902bef126de880448977307fe7d6bcc9a5d4 (diff)
downloadkolla-ansible-a3badc9325e53d875b30f3b89947e7e2e2863781.tar.gz
kolla-ansible-a3badc9325e53d875b30f3b89947e7e2e2863781.zip
Fix compare_labels when image doesn't exist22.2.0
check_image() from kolla_docker_worker returns None when the image doesn't exist locally. This means that when compare_labels tries to read a value from it, it will error out. This chain happens when comparing an image that doesn't exist locally. In the past we didn't hit this because checks ran sequentially and it would exit before hitting this. A recent change [1] means that now all checks run always. This patch fixes the issue in two ways. First, it makes the docker worker return an empty dict from check_image when it doesn't exist. Second, compare_labels now truthy-checks the output before proceeding, and returns straight away if it's False. [1] https://review.opendev.org/c/openstack/kolla-ansible/+/978162 Change-Id: I3c33ac3a474f80bca100005f61c1c0bfedc46170 Signed-off-by: Alex Welsh <alex@stackhpc.com> Closes-Bug: #2166024 (cherry picked from commit ffc50e8d33ade7a0d58ef83b79ed296a28b49608)
Diffstat (limited to 'deploy-guide')
0 files changed, 0 insertions, 0 deletions