aboutsummaryrefslogtreecommitdiff
path: root/ansible
diff options
context:
space:
mode:
authorMichal Nasiadka <mnasiadka@gmail.com>2025-11-12 14:31:39 +0100
committerMichal Nasiadka <mnasiadka@gmail.com>2025-11-24 09:12:50 +0000
commit7152b97a16cef6042d9dfb0bfa91f50868ba2c7c (patch)
tree80d5c105aaf5e38dbcd8fb09bdcd0af1d8c70fd8 /ansible
parent9171b0e5a1bb2acd62be80f3894600a2bba45cce (diff)
downloadkolla-ansible-7152b97a16cef6042d9dfb0bfa91f50868ba2c7c.tar.gz
kolla-ansible-7152b97a16cef6042d9dfb0bfa91f50868ba2c7c.zip
ansible-lint: Fix yaml[truthy] in mariadb role
Change-Id: Iebf507ea4c970bbde896bd8fde344f433b6e6366 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
Diffstat (limited to 'ansible')
-rw-r--r--ansible/roles/mariadb/tasks/backup.yml4
-rw-r--r--ansible/roles/mariadb/tasks/bootstrap_cluster.yml2
-rw-r--r--ansible/roles/mariadb/tasks/check.yml2
-rw-r--r--ansible/roles/mariadb/tasks/loadbalancer.yml4
-rw-r--r--ansible/roles/mariadb/tasks/lookup_cluster.yml6
-rw-r--r--ansible/roles/mariadb/tasks/post-upgrade.yml2
-rw-r--r--ansible/roles/mariadb/tasks/recover_cluster.yml10
-rw-r--r--ansible/roles/mariadb/tasks/register.yml4
8 files changed, 17 insertions, 17 deletions
diff --git a/ansible/roles/mariadb/tasks/backup.yml b/ansible/roles/mariadb/tasks/backup.yml
index 0ddd8521d..c07d7ded6 100644
--- a/ansible/roles/mariadb/tasks/backup.yml
+++ b/ansible/roles/mariadb/tasks/backup.yml
@@ -17,14 +17,14 @@
action: "start_container"
command: "bash -c 'sudo -E kolla_set_configs && /usr/local/bin/{{ cmd }}'"
common_options: "{{ docker_common_options }}"
- detach: False
+ detach: false
# NOTE(mgoddard): Try to use the same image as the MariaDB server container
# to avoid compatibility issues. See
# https://bugs.launchpad.net/kolla-ansible/+bug/2058644.
image: "{{ container_facts.containers[mariadb_services.mariadb.container_name].Config.Image | default(mariadb_services.mariadb.image) }}"
name: "mariabackup"
restart_policy: oneshot
- remove_on_exit: True
+ remove_on_exit: true
environment:
BACKUP_TYPE: "{{ mariadb_backup_type }}"
volumes:
diff --git a/ansible/roles/mariadb/tasks/bootstrap_cluster.yml b/ansible/roles/mariadb/tasks/bootstrap_cluster.yml
index 9a412c357..34c463cb8 100644
--- a/ansible/roles/mariadb/tasks/bootstrap_cluster.yml
+++ b/ansible/roles/mariadb/tasks/bootstrap_cluster.yml
@@ -7,7 +7,7 @@
kolla_container:
action: "start_container"
common_options: "{{ docker_common_options }}"
- detach: False
+ detach: false
environment:
KOLLA_BOOTSTRAP:
KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
diff --git a/ansible/roles/mariadb/tasks/check.yml b/ansible/roles/mariadb/tasks/check.yml
index c0296bd4c..78d5e481d 100644
--- a/ansible/roles/mariadb/tasks/check.yml
+++ b/ansible/roles/mariadb/tasks/check.yml
@@ -15,7 +15,7 @@
query: "SHOW DATABASES;"
register: result
until: result is success
- changed_when: False
+ changed_when: false
retries: 6
delay: 10
become: true
diff --git a/ansible/roles/mariadb/tasks/loadbalancer.yml b/ansible/roles/mariadb/tasks/loadbalancer.yml
index bc7439dfd..9bfa2ac6c 100644
--- a/ansible/roles/mariadb/tasks/loadbalancer.yml
+++ b/ansible/roles/mariadb/tasks/loadbalancer.yml
@@ -37,8 +37,8 @@
with_dict: "{{ mariadb_shards_info.shards }}"
loop_control:
label: "{{ host }}"
- failed_when: False
- run_once: True
+ failed_when: false
+ run_once: true
- name: "Configure loadbalancer for {{ project_name }}"
import_role:
diff --git a/ansible/roles/mariadb/tasks/lookup_cluster.yml b/ansible/roles/mariadb/tasks/lookup_cluster.yml
index 207e1f90b..5103af072 100644
--- a/ansible/roles/mariadb/tasks/lookup_cluster.yml
+++ b/ansible/roles/mariadb/tasks/lookup_cluster.yml
@@ -27,7 +27,7 @@
timeout: 10
search_regex: "MariaDB"
register: check_mariadb_port_liveness
- ignore_errors: yes
+ ignore_errors: true
- name: Divide hosts by their MariaDB service port liveness
group_by:
@@ -76,5 +76,5 @@
msg: MariaDB cluster is not synced. Please wait for WSREP sync before proceeding.
when:
- groups[mariadb_shard_group + '_port_alive_True'] is defined
- - groups[mariadb_shard_group + '_sync_status_Synced'] is not defined or
- groups[mariadb_shard_group + '_port_alive_True'] | sort != groups[mariadb_shard_group + '_sync_status_Synced'] | sort
+ - groups[mariadb_shard_group + '_sync_status_Synced'] is not defined or groups[mariadb_shard_group + '_port_alive_True'] | sort !=
+ groups[mariadb_shard_group + '_sync_status_Synced'] | sort
diff --git a/ansible/roles/mariadb/tasks/post-upgrade.yml b/ansible/roles/mariadb/tasks/post-upgrade.yml
index ac878bef6..70a184812 100644
--- a/ansible/roles/mariadb/tasks/post-upgrade.yml
+++ b/ansible/roles/mariadb/tasks/post-upgrade.yml
@@ -7,7 +7,7 @@
kolla_container:
action: "start_container"
common_options: "{{ docker_common_options }}"
- detach: False
+ detach: false
dimensions: "{{ service.dimensions }}"
environment:
KOLLA_UPGRADE:
diff --git a/ansible/roles/mariadb/tasks/recover_cluster.yml b/ansible/roles/mariadb/tasks/recover_cluster.yml
index 37877ae59..0f1f0f9de 100644
--- a/ansible/roles/mariadb/tasks/recover_cluster.yml
+++ b/ansible/roles/mariadb/tasks/recover_cluster.yml
@@ -11,7 +11,7 @@
delegate_to: localhost
connection: local
changed_when: false
- check_mode: no
+ check_mode: false
run_once: true
with_fileglob: "/tmp/kolla_mariadb_recover_inventory_name_*"
@@ -61,7 +61,7 @@
path: /tmp/mariadb_tmp.log
state: absent
changed_when: false
- check_mode: no
+ check_mode: false
- name: Registering MariaDB seqno variable
set_fact:
@@ -102,10 +102,10 @@
- name: Set grastate.dat file from MariaDB container in bootstrap host
become: true
lineinfile:
- create: yes
+ create: true
dest: "{{ container_engine_volumes_path }}/mariadb/_data/grastate.dat"
- regexp: 'safe_to_bootstrap:(.*)$'
- line: 'safe_to_bootstrap: 1'
+ regexp: "safe_to_bootstrap:(.*)$"
+ line: "safe_to_bootstrap: 1"
state: present
when:
- bootstrap_host is defined
diff --git a/ansible/roles/mariadb/tasks/register.yml b/ansible/roles/mariadb/tasks/register.yml
index 1b733afa7..b7a73ce51 100644
--- a/ansible/roles/mariadb/tasks/register.yml
+++ b/ansible/roles/mariadb/tasks/register.yml
@@ -50,7 +50,7 @@
password: "{{ mariadb_backup_database_password }}"
host: "%"
priv: "*.*:RELOAD,PROCESS,LOCK TABLES,BINLOG MONITOR/{{ mariadb_backup_database_schema }}.mariadb_backup_history:CREATE,ALTER,INSERT"
- append_privs: True
+ append_privs: true
when:
- enable_mariabackup | bool
- inventory_hostname == mariadb_backup_host
@@ -70,7 +70,7 @@
password: "{{ mariadb_backup_database_password }}"
host: "%"
priv: "{{ mariadb_backup_database_schema }}.*:CREATE,INSERT,SELECT"
- append_privs: True
+ append_privs: true
when:
- enable_mariabackup | bool
- inventory_hostname == mariadb_backup_host