diff options
| author | Radosław Piliszek <radoslaw.piliszek@gmail.com> | 2020-07-31 17:54:52 +0200 |
|---|---|---|
| committer | Michal Arbet <michal.arbet@ultimum.io> | 2024-12-01 22:16:51 +0100 |
| commit | 345ecbf55e079c6f578302c3e2189fa56e4ff5fe (patch) | |
| tree | f1258a74b842593bebd9a113eca1f37901f32506 /ansible/library | |
| parent | 53376aed8fc8175a2e5a2ca69dfe15a56a16273f (diff) | |
| download | kolla-ansible-345ecbf55e079c6f578302c3e2189fa56e4ff5fe.tar.gz kolla-ansible-345ecbf55e079c6f578302c3e2189fa56e4ff5fe.zip | |
Refactor services' check-containers and optimise
This might fix some hidden bugs where the check tasks forgot to
include params important for the service.
We also get a nice optimisation by using a filtered loop instead
of task skipping per service with 'when'. As proven in
https://review.opendev.org/c/openstack/kolla-ansible/+/914997
This refactoring allows for further optimisation and
fixing work to proceed with much less hassle. Including getting
rid of many notify statements as the restarts are now safely handled
by check-containers. Some notifies had to stay, because of special
edge cases eg. in rolling upgrades and loadbalancer config.
One downside is we remove the little optimisation for Zun that
ignored config change for copying loopback but this is an
acceptable tradeoff considering the benefits above.
Co-Authored-By: Roman Krček <roman.krcek@tietoevry.com>
Change-Id: I855dfef33aa0f3fd1301295bb8ede3e587e7162a
Partially-Implements: blueprint performance-improvements
Diffstat (limited to 'ansible/library')
| -rw-r--r-- | ansible/library/kolla_container.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ansible/library/kolla_container.py b/ansible/library/kolla_container.py index a2cf44daa..a4eaaaedd 100644 --- a/ansible/library/kolla_container.py +++ b/ansible/library/kolla_container.py @@ -267,6 +267,8 @@ EXAMPLES = ''' def generate_module(): # NOTE(jeffrey4l): add empty string '' to choices let us use # pid_mode: "{{ service.pid_mode | default ('') }}" in yaml + # NOTE(r-krcek): arguments_spec should also be reflected in the list of + # arguments in service-check-containers role argument_spec = dict( common_options=dict(required=False, type='dict', default=dict()), action=dict(required=True, type='str', |