aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.opendev.org>2024-06-26 17:37:44 +0000
committerGerrit Code Review <review@openstack.org>2024-06-26 17:37:44 +0000
commit35e9a1f5b293b8a30462c70945fea47fec443897 (patch)
treedf919b4a53695ab145f86e5ef1c96bed3ddb1ec3
parent9a45b3db514ac2e2c3b3cb054b975eab6d158fe3 (diff)
parent9b3428c5046ec5032585bd6ea9baa50da3d82a4b (diff)
downloadkolla-ansible-35e9a1f5b293b8a30462c70945fea47fec443897.tar.gz
kolla-ansible-35e9a1f5b293b8a30462c70945fea47fec443897.zip
Merge "Support mode in named volumes when using podman"
-rw-r--r--ansible/module_utils/kolla_podman_worker.py8
-rw-r--r--releasenotes/notes/fixes-podman-named-volume-issues-when-using-mode-36b9862321eb9e68.yaml6
2 files changed, 12 insertions, 2 deletions
diff --git a/ansible/module_utils/kolla_podman_worker.py b/ansible/module_utils/kolla_podman_worker.py
index 1f9b57067..a5bd9bbcb 100644
--- a/ansible/module_utils/kolla_podman_worker.py
+++ b/ansible/module_utils/kolla_podman_worker.py
@@ -177,7 +177,11 @@ class PodmanWorker(ContainerWorker):
mounts.append(mount_item)
else:
try:
- src, dest = item.split(':')
+ mode = 'rw'
+ if item.count(':') == 2:
+ src, dest, mode = item.split(':')
+ else:
+ src, dest = item.split(':')
except ValueError:
self.module.fail_json(
msg="Wrong format of volume: {}".format(item),
@@ -192,7 +196,7 @@ class PodmanWorker(ContainerWorker):
else:
filtered_volumes[src] = dict(
bind=dest,
- mode='rw'
+ mode=mode
)
def parse_dimensions(self, dimensions):
diff --git a/releasenotes/notes/fixes-podman-named-volume-issues-when-using-mode-36b9862321eb9e68.yaml b/releasenotes/notes/fixes-podman-named-volume-issues-when-using-mode-36b9862321eb9e68.yaml
new file mode 100644
index 000000000..06821859e
--- /dev/null
+++ b/releasenotes/notes/fixes-podman-named-volume-issues-when-using-mode-36b9862321eb9e68.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+ - |
+ Fixes an issue, when using podman, with named volumes that use a mode
+ specifier. See `LP#2054834
+ <https://bugs.launchpad.net/kolla-ansible/+bug/2054834>`_ for more details.