diff options
| author | Zuul <zuul@review.opendev.org> | 2025-12-04 14:59:50 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2025-12-04 14:59:50 +0000 |
| commit | 0851b23bbbd194bb4c718625942506a0258e3f6b (patch) | |
| tree | e407dae1fcffb2f213bc1b80b0cb2880053d36ff | |
| parent | 62b683df800f88015a36d277f852e739b095b311 (diff) | |
| parent | c868e52a776fa1299d849dcd9c8177e72bc05472 (diff) | |
| download | kolla-ansible-0851b23bbbd194bb4c718625942506a0258e3f6b.tar.gz kolla-ansible-0851b23bbbd194bb4c718625942506a0258e3f6b.zip | |
Merge "ansible-lint: Add noqa to existing no-handler violations"
| -rw-r--r-- | .ansible-lint | 2 | ||||
| -rw-r--r-- | ansible/roles/bifrost/tasks/reconfigure.yml | 2 | ||||
| -rw-r--r-- | ansible/roles/nova/tasks/map_cell0.yml | 2 | ||||
| -rw-r--r-- | ansible/roles/octavia/tasks/hm-interface.yml | 6 | ||||
| -rw-r--r-- | ansible/roles/rabbitmq/tasks/bootstrap.yml | 2 |
5 files changed, 6 insertions, 8 deletions
diff --git a/.ansible-lint b/.ansible-lint index f2c17a60c..0585097b6 100644 --- a/.ansible-lint +++ b/.ansible-lint @@ -9,8 +9,6 @@ exclude_paths: strict: false use_default_rules: true skip_list: - # [E503] Tasks that run when changed should likely be handlers - - no-handler # [unnamed-task] All tasks should be named # FIXME(mgoddard): Add names to all tasks - unnamed-task diff --git a/ansible/roles/bifrost/tasks/reconfigure.yml b/ansible/roles/bifrost/tasks/reconfigure.yml index 5ec184ff9..8cfd91965 100644 --- a/ansible/roles/bifrost/tasks/reconfigure.yml +++ b/ansible/roles/bifrost/tasks/reconfigure.yml @@ -57,7 +57,7 @@ - "{{ check_results.results }}" - include_tasks: start.yml - when: remove_containers.changed + when: remove_containers.changed # noqa no-handler - name: Restart containers become: true diff --git a/ansible/roles/nova/tasks/map_cell0.yml b/ansible/roles/nova/tasks/map_cell0.yml index e9acab03d..612a6426a 100644 --- a/ansible/roles/nova/tasks/map_cell0.yml +++ b/ansible/roles/nova/tasks/map_cell0.yml @@ -65,4 +65,4 @@ - nova_cell_settings.cell_database != nova_cell0_connection - include_tasks: bootstrap_service.yml - when: map_cell0.changed + when: map_cell0.changed # noqa no-handler diff --git a/ansible/roles/octavia/tasks/hm-interface.yml b/ansible/roles/octavia/tasks/hm-interface.yml index 79790d471..a04c14358 100644 --- a/ansible/roles/octavia/tasks/hm-interface.yml +++ b/ansible/roles/octavia/tasks/hm-interface.yml @@ -37,7 +37,7 @@ {% if openstack_cacert != '' %}--os-cacert {{ openstack_cacert }} {% endif %} port set --host {{ ansible_facts.nodename }} {{ port_id }} when: - - port_info.changed + - port_info.changed # noqa no-handler - name: Add Octavia port to openvswitch br-int vars: @@ -77,7 +77,7 @@ name: octavia-interface daemon_reload: true state: restarted - when: octavia_interface.changed + when: octavia_interface.changed # noqa no-handler - name: Enable and start octavia-interface.service become: true @@ -100,4 +100,4 @@ # network device(o-hm0) which is not collected, so we need gather facts again - name: Gather facts setup: - when: octavia_interface.changed + when: octavia_interface.changed # noqa no-handler diff --git a/ansible/roles/rabbitmq/tasks/bootstrap.yml b/ansible/roles/rabbitmq/tasks/bootstrap.yml index 97822c2aa..8981d588d 100644 --- a/ansible/roles/rabbitmq/tasks/bootstrap.yml +++ b/ansible/roles/rabbitmq/tasks/bootstrap.yml @@ -23,4 +23,4 @@ name: "{{ project_name }}_bootstrap" restart_policy: oneshot volumes: "{{ service.volumes }}" - when: rabbitmq_volume is changed + when: rabbitmq_volume is changed # noqa no-handler |